[$1000] [HOLD for payment 2023-07-14] Back button is not working on select a currency page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB > Request money
2. Click on the currency
3. Click on the back button at the top

Expected Result:

Back button should take user back and it should work properly

Actual Result:

Back button is not working and console error occurs

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.36-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.1134.mp4

2023-07-03.21.18.46.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688408446305599

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01805773f0aa3fe2ec
• Upwork Job ID: 1679105288887033856
• Last Price Increase: 2023-07-12

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dangrous]

Ah it's this line -

App/src/pages/iou/IOUCurrencySelection.js

Line 117 in e7a17f8

onBackButtonPress={() => Navigation.goBack(ROUTES.getIouRequestRoute(Navigation.getTopmostReportId()))}

- ROUTES.getIouRequestRoute() doesn't actually exist. Need to figure out what it's supposed to do and fix it...

cc @Julesssss in case you know (since it's your PR)

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Navigation from IOU's Currency Selection screen to previous screen is not working on back button press.

What is the root cause of that problem?

• getIouRequestRoute function does not exist in ROUTES object. Probably removed when we removed IOU's paths and replace with MONEY_REQUEST's paths.

What changes do you think we should make in order to solve the problem?

• We can use getMoneyRequestRoute function instead of getIouRequestRoute function. And pass ROUTES.IOU_REQUEST as iouType.

File src/pages/iou/IOUCurrencySelection.js

<HeaderWithBackButton
    title={translate('iOUCurrencySelection.selectCurrency')}
-    onBackButtonPress={() => Navigation.goBack(ROUTES.getIouRequestRoute(Navigation.getTopmostReportId()))}
+    onBackButtonPress={() => Navigation.goBack(ROUTES.getMoneyRequestRoute(ROUTES.IOU_REQUEST))}
/>

• We are not passing reportID as it will always navigate back to new money request.

What alternative solutions did you explore? (Optional)

• N/A

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[dangrous]

@jeet-dhandha thanks for the suggestion! In this case, we actually DO need the reportID if we're requested money from inside an already existing money request, and the IOU type also changes depending on if it's a money request, bill split, etc.

You can check out the PR to see what we ended up going with!

[jeet-dhandha]

Cool 👍 . Glad to be of Help.

[Julesssss]

Fix PR is just awaiting a C+ review 👍

[Julesssss]

Pr merged, now CPing

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix broken back button on currency select #22135

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dangrous] The PR that introduced the bug has been identified. Link to the PR:
• [@dangrous] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dangrous] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dangrous] Determine if we should create a regression test for this bug.
• [@dangrous] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dangrous]

why did we get this checklist twice?

Answers copied here.

PR has been commented on.

I'm guessing we already have this as a regression test, but if not, it should be:

1. Click on FAB > Request money
2. Click on the currency
3. Click on the back button at the top
4. Back button should take user back and it should work properly

@Julesssss do you think we need a discussion in #expensify-bugs? I think it's just double checking any merge conflicts, which is generally the procedure, so I don't think we need anything new.

[Julesssss]

do you think we need a discussion in #expensify-bugs? I think it's just double checking any merge conflicts, which is generally the procedure, so I don't think we need anything new.

Nah I think we're good. This was raised by a regression test anyway.

[dangrous]

Adding @abdulrahuman5196 so they can get paid for PR review when the time comes

[laurenreidexpensify]

This has been on prod #22135 (comment) for 7 days, so I'm going to pay now

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01805773f0aa3fe2ec

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.

[laurenreidexpensify]

@abdulrahuman5196 pls apply here in Upwork https://www.upwork.com/jobs/~01805773f0aa3fe2ec thanks

[Nathan-Mulugeta]

Hey @laurenreidexpensify I also applied for the reporting bonus

[abdulrahuman5196]

Thank you @laurenreidexpensify. Applied.

[abdulrahuman5196]

Not overdue.

@laurenreidexpensify Pending on the payment on this issue

[laurenreidexpensify]

Apols @abdulrahuman5196 @Nathan-Mulugeta - offers now sent in Upwork

[abdulrahuman5196]

@laurenreidexpensify accepted the invite

[Nathan-Mulugeta]

Accepted offer

[laurenreidexpensify]

Payments issued, closing