[HOLD for payment 2023-10-25] [$1000] Chat - Emoji suggestion list does not disappear when typing 👍 in the composer

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Go to any conversation
3. Type 👍 in the composer

Expected Result:

When the emoji is rendered, the emoji suggestion list will disappear

Actual Result:

When the emoji is rendered, the emoji suggestion list does not disappear

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6097879_Screen_Recording_20230619_042507_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c88e94973fd21352
• Upwork Job ID: 1671501364638490624
• Last Price Increase: 2023-07-12
• Automatic offers:
• aimane-chnaif | Reviewer | 27373764
• ShogunFire | Contributor | 27373765

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji suggestions do not reset when typing 👍 in composer on android chrome

What is the root cause of that problem?

The root cause of the issue is that once the suggestion text is matched to contain an Emoji here, the subsequent state update (with text replaced with emoji), does not trigger onSelectionChange event on Android chrome. Since the onSelectionChange event is not triggered, the emoji suggestions do not get re-calculated. Thus the suggestion menu keeps on showing.

What changes do you think we should make in order to solve the problem?

We should reset the suggested emojis in the updateComment function if the text matches an emoji code. For example, here, we need to add:

...!_.isEmpty(emojis) && {suggestedEmojis: []},

This can be done for all the platforms or for android chrome only.

What alternative solutions did you explore? (Optional)

Instead of setting emoji state to [], we can also call this.calculateEmojiSuggestions in the same function.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c88e94973fd21352

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[flaviadefaria]

The external label has been added.

[ShogunFire]

Just to add to @allroundexperts proposal, the reason onSelectionChange is not called on Android is because onSelectionChange is called after OnChangeText on Android whereas on others platforms it is called before. And the selection doesn't change because the length of ":+1" is 3 and the length of "👍 " is also 3.

[flaviadefaria]

@aimane-chnaif what are your thoughts here?

[flaviadefaria]

Friendly bump @aimane-chnaif

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[flaviadefaria]

@aimane-chnaif just checking if you need any help?

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

[NicMendonca]

I was hoping that would recreate the since expired Upwork job 😄

[aimane-chnaif]

@NicMendonca please try this approach:

• remove Awaiting Payment label
• unassign @ShogunFire
• add Help Wanted label
• assign @ShogunFire

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ShogunFire 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[NicMendonca]

@aimane-chnaif you hero!

[NicMendonca]

can you both accept the offers please? 🙏

[aimane-chnaif]

BZ Checklist:
I have same proposal as #27156 (comment)

So if regression test is already created,

1. Open the app
2. Open any report
3. Type in ':eye' to open emoji suggestion list -> update this to "Type in ':eye' or ':+1' to open emoji suggestion list"
4. Add a colon at the end to insert the emoji
5. Verify that the suggestion list closes

[ShogunFire]

I accepted the offer

[NicMendonca]

@aimane-chnaif just need you to accept the off please!

[NicMendonca]

@ShogunFire you've been paid! 🎉

[NicMendonca]

everyone has been paid! ✅

[ShogunFire]

@NicMendonca Hello, sorry for the late request but could you put the upwork mission as completed ? Because it makes my upwork profile worse otherwise. Thanks

[stephanieelliott]

Hello, sorry for the late request but could you put the upwork mission as completed ? Because it makes my upwork profile worse otherwise. Thanks

I took care of this!