[HOLD for payment 2023-07-14] Up button does not redirect to LHN when other chats are opened previously and window was resized to mobile

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #19263

Action Performed:

Scenario 1:

1. Go to https://staging.new.expensify.com/
2. Make sure that user lands on Chat A (other than Concierge).
3. Go to Concierge chat.
4. Resize the window to half the size to trigger mobile interface.
5. Click Back icon on the page.

Scenario 2:

1. Go to https://staging.new.expensify.com/
2. Make sure that user lands on Chat A (other than Concierge).
3. Go to Chat B, C and D.
4. Go to Concierge chat.
5. Resize the window to half the size to trigger mobile interface.
6. Click Back icon on the page.

Expected Result:

User is redirected to LHN.

Actual Result:

Scenario 1: User is redirected to Chat A. User needs to click on the back button again to return to LHN.

Scenario 2: User is redirected to chats that are opened previously (Chat D, C, B and A). User needs to click on the back button several times to return to LHN.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.25.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6083475_Scenario_1.mp4

Bug6083475_Scenario_2.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ebf41decd730ce26
• Upwork Job ID: 1679926062239186944
• Last Price Increase: 2023-07-14

[roryabraham]

I'm actually unsure if this is expected behavior or not

[roryabraham]

I think in any event we should not block deploys on this, so I'm going to demote it.

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[roryabraham]

It's actually unclear to me that this is even a bug, so I'm going to assign this to @mountiny who will have better context on how to address this issue, even if it's just to close it.

[mountiny]

Noting here that this is something we will have to discuss with @WoLewicki and @adamgrzybowski how to solve the best in general, I will make this weekly as they are both ooo til next week

[parasharrajat]

This is a bug. On Mobile interfaces, we should take the user back to LHN(HOME) page instead of going back in the stack. Otherwise, the app will become hard to use. So this Back arrow on report title is not back button but back to LHN. If user want to navigate in the history they have hardware back button.

[mountiny]

This is a bug. On Mobile interfaces, we should take the user back to LHN(HOME) page instead of going back in the stack. Otherwise, the app will become hard to use. So this Back arrow on report title is not back button but back to LHN. If user want to navigate in the history they have hardware back button.

This is not completely right, the back arrow button is still up in stack for example if you go to thread or iou report on mobile. The issue is to handle this after resize, we need to add the LHN to the stack before the latest report so clicking UP brings you to the LHN

[parasharrajat]

Yeah, I agree. There are few pages where back arrow is up action.

[mountiny]

Making it Daily again to be worked on by SWM

[esh-g]

Hey, I just wanted to drop in some information if it would be useful in this case:

It is possible to use the logic from subscribeToReportCommetPushNotifications

App/src/libs/Notification/PushNotification/subscribeToReportCommentPushNotifications.js

Lines 22 to 25 in 8bd25c7

	if (Navigation.getActiveRoute().slice(1, 2) === ROUTES.REPORT && !Navigation.isActiveRoute(`r/${reportID}`)) {
	Navigation.goBack();
	}
	Navigation.navigate(ROUTES.getReportRoute(reportID));

And use it in SidebarLinks.js

App/src/pages/home/sidebar/SidebarLinks.js

Lines 140 to 147 in 2a1c36d

	showReportPage(option) {
	if (this.props.isCreateMenuOpen) {
	// Prevent opening Report page when click LHN row quickly after clicking FAB icon
	return;
	}
	Navigation.navigate(ROUTES.getReportRoute(option.reportID));
	this.props.onLinkClick();
	}

This will make sure that if we click on another report, the previous one is popped off the stack and only then the new one opens. I'm not sure if this is the intended approach that we should choose but I had research about this and thought to leave this comment

[mountiny]

Thanks, still waiting for swm to find time for this one

[s77rt]

• The PR that introduced the bug has been identified: Use goBack so that the < works for threads and other chats #18350
• The offending PR has been commented on: Use goBack so that the < works for threads and other chats #18350 (comment)
• A discussion in #expensify-bugs has been started: This is an edge case, I doubt it could have been caught during PR testing and there is pretty much nothing to discuss here.
• Determine if we should create a regression test for this bug: Given this is an edge case (unlikely to be reproduced by a real user) I'm leaning towards a No.

[s77rt]

@mountiny Can you please remove/add Bug label to auto-assign a BZ member here.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

Payment is due at the end of the week

[alexpensify]

I'm catching up from being OOO, it looks like payment is due on July 14.

[alexpensify]

Since this is a payment, I've updated it to Weekly.

[alexpensify]

@mountiny - can you please share what the payment structure should be here? Also, is there an Upwork job to send over and assign to @s77rt? Thanks!

[mountiny]

$1000 to @s77rt for internal PR review

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ebf41decd730ce26

[melvin-bot]

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

[alexpensify]

There we go! @s77rt I've prepared the payment process in Upwork. Please accept and I can close this GH. Thank you!

[s77rt]

@alexpensify Accepted! Thanks!

[alexpensify]

@s77rt has been paid via Upwork and I closed the job there. I'm going to close this GH too.