-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Polish] Make the RHP animations always working on web and they are smooth #20342
Comments
Triggered auto assignment to @MitchExpensify ( |
Commenting |
Focusing on bugs now |
@WoLewicki @adamgrzybowski will you or anyone from SWM be able to pick this up as with animations its best to utilize you? |
I still have some other tasks on my plate. But I could look at this later, or sooner if the priority is high. |
Hi, I will have a try on this task. I'm an external from SWM. |
Exciting! |
This is being worked on in the styling PR |
On hold for the styling issue still |
This issue has not been updated in over 15 days. @WoLewicki, @mountiny, @MitchExpensify eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
There is a PR actively being worked on |
@WoLewicki, @mountiny, @MitchExpensify, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
I think this was actually solved in most cases |
Clean up for the #11768
Problem
Because of using stack navigation for all the pages in the App, when we close a modal we lose the information about the route and what should be rendered so its not easy to animate closing the modal. We are showing or closing the RHP modal abruptly because of that.
Additionally if you navigate to a deeplink RHP like
settings/security
, we usereplace
to go up in the stack but those pages are not in the stack yet so animating to them is trickier.Additionally, thr animations are not smooth at all time which you can see on an attached video here
Screen.Recording.2023-06-07.at.09.46.36.mov
Why is it important
Animations give a better feel to the app and its important to keep the animations consistent
Solution
Lets ensure:
The text was updated successfully, but these errors were encountered: