App shows the same default avatar for every different account on new chat

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a new account on ND
2. Click on FAB and click on split bill
3. Enter amount and click next
4. Enter multiple different account emails and select them to split amount with them
5. Click on FAB and click on new chat
6. Observe the avatars of the recent contacts
7. Open each IOU thread and click on the IOU card to open the description thread. Do this for every account with whom amount was split between
8. Click on the FAB and click on new chat again
9. Observe the avatar of the recent contacts

Expected Result:

The default avatar should not revert back to show the same default avatar for every different contact

Actual Result:

App shows the same default avatar for every different account on the recent contact list. The default avatar shown is the same as the current user's default avatar.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-30.13.30.47.mp4

Recording.835.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685443348773429

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

@Nathan-Mulugeta @tjferriss this is basically the same issue with this #19370 where the new chat page shows the "owes you". I think we should just reopen that.

[melvin-bot]

@tjferriss Huh... This is 4 days overdue. Who can take care of this?

[tjferriss]

@Nathan-Mulugeta are you still able to reproduce this issue?

It looks like this PR is related and should have fixed this: #19392. Could this be a regression? @thienlnam @thesahindia

[Nathan-Mulugeta]

Hey @tjferriss I just tested this out on latest version on staging and it is still present.

[thienlnam]

I'm not sure I am following what the issue is here - there seem to be different default avatars shown in the videos

[Nathan-Mulugeta]

Hey @thienlnam, if you watch the first attached video, you'll notice that the default avatars undergo a noticeable change at around 00:53 seconds.

[thienlnam]

Ah yeah thanks that helped. The linked PR might be related with the changes made in src/libs/SidebarUtils.js

[Nathan-Mulugeta]

I just tested the latest version on the staging environment, but it seems like the changes made in that PR didn't resolve the issue. Unfortunately, the problem is still there.

[thienlnam]

Actually, I don't think this is a bug and a dupe of #19652 - in the new chat page, those are IOU reports and show the same avatars as in the left hand nav.

The other question is whether it is expected behavior or not, which we're figuring out here: #19652