Chat - Multiline link structure changes if user adds emoji when editing

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app or go to staging.new.expensify.com
2. Navigate to any conversation
3. Send a message with a multiline hyperlink in the following format:
   multilinex
   Text
4. Click/Tap on the Edit icon to activate the edit message box
5. Edit the message and add any emoji inside message but do not edit the link

Expected Result:

Edited message still displays the hyperlink with the multiline format

Actual Result:

Multiline link structure changes if user adds emoji when editing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.17.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:
https://expensify.testrail.io/index.php?/tests/view/3467098

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/dd338a69358f7772aacd3f4ed98a0cef9e9b8baf591b83be3a1e51a57fec5c89

https://platform.applause.com/services/links/v1/external/78260a7b242fea9b7dc94c34a678643252deedf770a6bd504159c0d08e5eeaf1

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Multiline link structure changes if user adds emoji when editing

What is the root cause of that problem?

We're validating if the anchor text contains only emojis in the 'link' with rule in here

What changes do you think we should make in order to solve the problem?

We need to check if the anchor text g1 is multiline:

      if (g1.includes('/n') && g1.match(CONST.REG_EXP.EMOJIS) || !g1.trim()) {
          return match;
      }

What alternative solutions did you explore? (Optional)

NA

Result

[eh2077]

As confirmed from this comment #18386 (comment), it's intentional not to render multiline link if the link text contains emoji.

[MitchExpensify]

Agreed, this is not a bug