[HOLD for payment 2023-06-13] [$1000] Show assigned user as mention in the task preview

[thienlnam]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a task and select an assignee
2. Navigate to the assigned chat

Expected Result:

The task preview should show the assignee in a "mention" like view

Actual Result:

Just shows the task title

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013df24eedfe4e5c4e
• Upwork Job ID: 1658609112262893568
• Last Price Increase: 2023-05-16

[melvin-bot]

Triggered auto assignment to @kevinksullivan (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013df24eedfe4e5c4e

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @bondydaa (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[phuchoang23]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show assigned user as mention in the task preview

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

We need to get assignee email from props.action.taskAssignee and put it in this before task's title in this line

App/src/components/ReportActionItem/TaskPreview.js

Line 81 in 811c0f3

<Text>{taskTitle}</Text>

To style it as message mention. I think we can either:

• Make a copy of component MentionUserRenderer
• Or we can split component MentionUserRenderer so that we can reuse component presentation between MentionUserRenderer and TaskPreview or other place that need to render mentioned user.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show assigned user as mention in the task preview

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

Actually message in task preview is only has taskTitle is wrapped in text

App/src/components/ReportActionItem/TaskPreview.js

Line 81 in 811c0f3

<Text>{taskTitle}</Text>

To show assigned user as mention in the task preview, we could create an html same as html for normal comment like this

const htmlForTaskPreview = `<comment><mention-user>@${props.action.taskAssignee}</mention-user> ${taskTitle}</comment>`;

to re-use mention style for mention-user tag. And then re-use RenderHTML component to render it in task preview

<RenderHTML html={htmlForTaskPreview} />

What alternative solutions did you explore? (Optional)

[kevinksullivan]

Unassigning as I am going OOO for several days

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[sobitneupane]

Thanks for the proposals.

@dukenv0307 Looks like props.action.taskAssignee is not always defined. For instance, Create a new task with different person as assignee and Share Somewhere.

[dukenv0307]

@sobitneupane Thanks for instance, I saw that props.action is different between assignee and share somewhere and the reason may come from BE. So to work for all case we can use props.action.assignee || props.taskReport.managerEmail.

[phuchoang23]

@sobitneupane I think we can use props.taskReport.participants to show assignee list.

[sobitneupane]

I am getting some weird issue. Sometimes even task title is missing in task report and is show as undefined.

I was able to reproduce this issue after I logout and login again.

const taskTitle = props.action.taskTitle || props.taskReport.reportName;

Even props.taskReport is missing in this case.

To extract taskTitle, similar approach as discussed by @dukenv0307 here is used. So, I thought we would be good to use props.action. taskAssignee || props.taskReport.managerEmail to extract assigned user but I cannot confirm props.taskReport.managerEmail is always present(as it is not present in above case).

[dukenv0307]

@sobitneupane Above case seems to be an other bug in here #19090

[thienlnam]

I've linked a couple issues that should also be solved by this.

Basically we should check the task report details first, and if those don't exist then fall back using the reportAction data (the report task should have the latest data)

[dukenv0307]

@sobitneupane The PR ready to review

[bondydaa]

pr was merged so dropping this to weekly

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show assigned user as mention in the task preview #19990

If no regressions arise, payment will be issued on 2023-06-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Checklist won't be required for this issue as we are not solving a bug here.

[thienlnam]

Noting there was a regression added from this PR #20539

[trjExpensify]

Okay, following the history I don't think this qualifies for the #efficiency bonus:

• we took this off hold on May 30th, so the count starts from then instead of when the issue was assigned - 4:17pm BST
• Merged on June 5th - 8.20pm BST
• Despite June 3rd & June 4th being the weekend, that's still not within 3 business days of the count (which would have been Friday June 2nd at 4:17pm BST.

And with the regression here, that makes it:

• @dukenv0307 - $1000 for the fix (we are in the process of implementing equal penalty for regressions, but that hasn't been introduced or announced just yet, so I'm not applying it here).
• @sobitneupane - $500 for C+
• @thienlnam - $0 for the bug report 😛

Does that sound right to everyone?

[trjExpensify]

@dukenv0307 can I get your upwork profile please?

[dukenv0307]

@trjExpensify my Upwork profile: https://www.upwork.com/freelancers/~01f5cbe690701118a2. Thanks.

[trjExpensify]

Thanks, sent you an offer! :)

[trjExpensify]

Settled up with you both!