3Eyed todd appears when opening a thread for the first time

[grgia]

Create a new thread.
Open it for the first time.
3 eyed todd Report not found will flash for a second

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01928b8639df6e206a

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[grgia]

https://github.com/Expensify/App/blob/main/src/pages/home/ReportScreen.js#L234-L243

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[jasperhuangg]

Sorted out the regression in a new PR, all good here!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Image Flashing Bug #19056

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[aimane-chnaif]

@grgia did we find ideal solution to fix this bug?

[grgia]

@aimane-chnaif PR was merged #19056
Although it seems this issue may still be occurring on native (separate issue from what was being fixed in the PR)

[aimane-chnaif]

@grgia it was reverted. Here's the reason: #19056 (comment)

-                       shouldShow={(!this.props.report.reportID && !this.props.report.isLoadingReportActions && !isLoading) || shouldHideReport}
+                       shouldShow={(!reportID && !this.props.report.isLoadingReportActions && !isLoading) || shouldHideReport}

This change doesn't exist in main anymore

[grgia]

Ah thank you @aimane-chnaif, I'll look into an alternative solution

[grgia]

haven't had a chance to look at this one again yet, should be able to this week

[grgia]

I plan on looking at this bug today and next week

[grgia]

I am unable to reproduce, @chiragsalian I saw in the deploy blocker issue you pushed a fix as well- did that cover this issue?

[grgia]

Nevermind, I am able to reproduce after logging out and logging back in

[grgia]

Now unable to reproduce again, curious if navigation changes affected this. @aimane-chnaif if you have a moment, would you mind testing if you're able to reproduce this bug?

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aimane-chnaif]

There was a recent change when open thread report first time. Might be related to #19580 which always creates first report action optimistically, no matter thread.

I just tested yesterday's codebase (before navigation refactor merged).
3Eyed todd gone but still have issue of empty chat before loading messages. But there's already issue for that.

[grgia]

Alright, I'm going to close this one out in that case as I'm also not able to reproduce

[aimane-chnaif]

@grgia a bit late but I finally found the PR which fixed this.
The dup issue was created and being worked on: #19364