[HOLD for payment 2023-05-25] [$1000] Blue bottom border seperator among currencies is not pressent.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open “Actions”
2. Open “Request money”
3. Click “Select a Currency”.
4. Observe there is no separator among currencies.
5. Open “Settings”
6. Open “Profile”
7. Open “Pronouns”.
8. Open “Settings”
9. Open “Profile”
10. Open “Timezone”.

Expected Result:

Separator among currencies should be present like Pronouns or Timezone.

Actual Result:

Seperator among currencies is not pressent like Pronouns or Timezone.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug.mp4

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684006680335189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0142b4e1af1a58a18d
• Upwork Job ID: 1658261573115326464
• Last Price Increase: 2023-05-16

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Blue bottom border separator among currencies is not present.

What is the root cause of that problem?

• The root cause is we are using <OptionsSelector> without shouldHaveOptionSeparator props inside IOUCurrencySelection.js which causes no separator

What changes do you think we should make in order to solve the problem?

• We just need to add shouldHaveOptionSeparator props inside <OptionsSelector> which is being used in IOUCurrencySelection.js that will resolve border issue which will make consistency with others selector as well

What alternative solutions did you explore? (Optional)

• None

Result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0142b4e1af1a58a18d

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

@dhairyasenjaliya Thanks for the proposal. Your RCA is correct and your proposed fix makes sense.

🎀 👀 🎀 C+ reviewed

cc @grgia

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job by @grgia!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dhairyasenjaliya]

alright thank you @s77rt @grgia will prepare PR within hour

[dhairyasenjaliya]

@s77rt PR ready for review

[kevinksullivan]

Offers sent in upwork @dhairyasenjaliya @s77rt @usmantariq96

[usmantariq96]

@kevinksullivan Offer accepted.

Thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat: Adding border Separator to currency selection Page #19002

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kevinksullivan]

Hi @s77rt please complete the steps above and I'll get this paid out next week assuming no regressions!

[s77rt]

• The PR that introduced the bug has been identified: No PR to blame. The currency page was implemented on May 2021 (PR) and at that time we didn't even have the option to add a separator. The separator feature was added later on Nov 2022 (PR).
• The offending PR has been commented on: n/a
• A discussion in #expensify-bugs has been started: Not a bug. This is a feature request.
• Determine if we should create a regression test for this bug: No

[s77rt]

@kevinksullivan Done!

[kevinksullivan]

Thanks for the quick turnaround @s77rt !

[kevinksullivan]

Paid everyone. @usmantariq96 I paid you for reporting, but upwork is bugging again and I can't close the contract. I'll try again tomorrow to wrap this up.

[kevinksullivan]

All set in ending the contract @usmantariq96