[HOLD for payment 2023-06-08] [HOLD] [Moderation] Create FlagCommentPage

[dangrous]

Part of NewDot Moderation - Tracking Issue and Design Doc

Design Doc Section

---

Routing

Add the new route to ModalStackNavigators.js with the name 'FlagComment_Root'
Since each report is flagged on a reportAction, we will update the route to include the reportActionID in ROUTES.js like flag/:reportActionID
Update linkingConfig.js to use that new route added above

These will be created in a similar manner to our Settings page. After a header section:

ScreenWrapper includeSafeAreaPaddingBottom={false}>
{({safeAreaPaddingBottomStyle}) => (
<>
<HeaderWithCloseButton
title={this.props.translate('flags.flagAsOffensive')
onCloseButtonPress={() => Navigation.dismissModal(true)}
/>
<View style={styles.pageWrapper}>
<View style={[styles.settingsPageBody, styles.alignItemsCenter]}>
<Text style={[styles.baseFontStyle]}>
{this.props.translate('initialSettingsPage.aboutPage.description')}
</Text>
</View>
</View>
<Text style={[styles.ph5, styles.textLabelSupporting, styles.mb1]}>
{this.props.translate('flags.chooseReasonBelow’}
</Text>

We’ll create a list of MenuItems with the appropriate severity and format:

<MenuItem
shouldShowRightIcon
title={this.props.translate('flags.spam'}
description={this.props.translate('flags.spamDescription'}
onPress={() => this.FlagComment(CONST.FLAGS.SPAM)}
wrapperStyle={[styles.borderBottom]}
furtherDetails={this.props.translate('flags.sendAnonymousWarning'}
furtherDetailsIcon={Expensicons.CircleFlag}
furtherDetailsIconFill={colors.yellow}
/>

A couple new things to point out in that logic:

• We’ll create constants for the severity levels to ensure consistency
• We’ll also create constants for the possible flag states - pending, hidden, removed, rejected
• We’ll include a FlagComment function within the FlagCommentPage component, which will take the severity from the clicked menu item, combine it with the reportID, reportAction and the user, and call Report.FlagComment, detailed in the design doc. Since everything except the severity will be the same no matter which option is chosen, it makes the most sense to consolidate it into one function. Once it calls FlagComment, it will dismiss the modal by calling Navigation.dismissModal(true).
• We can create an array of the severity levels and map through them to create the necessary MenuItems to not repeat ourselves, but either way the end format will match the above.
• We will be updating MenuItem to take the new optional parameters above - furtherDetails, furtherDetailsIcon, furtherDetailsIconFill - and create the third line of details shown in the mocks. This will be done by adding an additional section to the bottom of the MenuItem text here. It will take a similar format:

{Boolean(props.furtherDetails) && (
<Text
style={[styles.furtherDetailsStyle]}
numberOfLines={1}
>
<Icon
src={props.furtherDetailsIcon}
fill={props.furtherDetailsIconFill}
               height={variables.iconSizeNormal}
               width={variables.iconSizeNormal}
               style={styles.m2}
          />
{props.furtherDetails}
</Text>
)}

The style will be the same as the description text style, but one font size smaller.

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[dangrous]

will get to this next week!

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @shmaxey (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[dangrous]

@shmaxey here's the deets on the copy! https://expensify.slack.com/archives/C03SSAQG5/p1684932257657339

[shmaxey]

Reviewing yellow columns here: https://docs.google.com/spreadsheets/d/1TvHXqVjPE8QU62Z546M9ESeGMo1JsCTKP3NBAKQtsW0/edit#gid=0

Done!

[shmaxey]

Shoot, sorry @dangrous - I'll leave this 👐

[dangrous]

Thank you @shmaxey!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.21-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create FlagCommentPage #19412

If no regressions arise, payment will be issued on 2023-06-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dangrous]

Not a bug, just getting a teammate to help with payment for @eVoloshchak's review

[isabelastisser]

@dangrous, please let me know what I need to do next. Create a job in Upwork and pay @eVoloshchak on June 8? What's the payment amount?

[dangrous]

I believe internal review is $1k (@eVoloshchak correct me if I'm wrong)! And yep, you got it - job for payment on 6/8.

[isabelastisser]

cool, thanks @dangrous ! ;)

[isabelastisser]

Not overdue. Payment on June 8!

[dangrous]

We're ready for payment @isabelastisser !

[dangrous]

@isabelastisser is out until Wednesday - @eVoloshchak are you okay with waiting until then? If it's pressing I can find another team member to help out.

[eVoloshchak]

@dangrous, sure, I can wait no problem

[isabelastisser]

@eVoloshchak sorry for the delay! I will issue the payment now.

[isabelastisser]

@eVoloshchak I extended the contract to you in Upwork now. Please accept it, and I will process the payment. Thanks!