[HOLD for payment 2023-06-29] [$1000] Delete popup is stuck and screen blinks for few seconds when user tries to delete a message and user gets removed from workspace at that instance

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app on any device and login with user A
2. Open the app on any other device and login with user B (ensure that user A is present in one of the workspace to which user B is admin)
3. On user A device, open workspace to which user B is admin
4. On user A device, right click or long press on any of the self message and click on delete message to open delete confirmation popup
5. From user B device, remove user A from that workspace
6. Observe on user A device, when user B removes user A from workspace, chat blinks by showing not access page, chat page and again not access page and also the delete popup is still open

Expected Result:

App should also close all the popups open on user A device when user B remove user A from workspace. App should also not blink the #announce chat for user A when user B removes user A from workspace

Actual Result:

App keeps the delete popup open even though user A is no longer able to able that chat. App also blinks the chat few times before displaying 'You don't have access' screen

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

delete.popup.remains.open.on.workspace.remove.mp4

Recording.323.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682176575452809

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ed03865c0010a59
• Upwork Job ID: 1651681139754299392
• Last Price Increase: 2023-06-09

[MelvinBot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alexpensify]

I'll try to test soon.

[MelvinBot]

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

This one is still on my radar to test.

[alexpensify]

I'm able to replicate

[MelvinBot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alexpensify]

@bondydaa - I think we take this to the room to identify how it should function but let me know if you have ideas then we assign it to External. Thanks!

[bondydaa]

Hmm I don't see why engineering label was added here, this should be fine for a contributor to work on so adding external label. Me asking in the room for ideas is the same as posting the external label no?

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~019ed03865c0010a59

[MelvinBot]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[MelvinBot]

Current assignee @bondydaa is eligible for the External assigner, not assigning anyone new.

[manish-tapadar-18]

@bondydaa If you are using websocket or any real time mechanism then easily you can solve this problem.
When someone remove a user from workspace we can easily send a real time packet and close the modal or popup.

[MelvinBot]

📣 @manish-tapadar-18! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[bondydaa]

Yep we are using web-socket via a service called Pusher which is how the report is able to get updated and show "not available" anymore. I think we just need to also dismiss the modal component somehow which I didn't dig into.

If you haven't already checkout https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md for how we typically expect proposals to come in (https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#propose-a-solution-for-the-job)

[chafikchaban]

Proposal

Please re-state the problem that we are trying to solve in this issue.

ActionContext menu delete modal is not closed when user gets removed from workspace.
( same goes for the context menu which IMO should also be closed in this case )

What is the root cause of that problem?

the ReportActionContextMenu is not aware of the changes, thus it keeps its states ( open context menu or delete modal )

What changes do you think we should make in order to solve the problem?

when a report update is received, in the case of a null report, invoke hideDeleteModal and hideContextMenu from ReportActionContextMenu in Report.js#L688

results:

Screen.Recording.2023-04-28.at.12.26.46.AM.mov

Screen.Recording.2023-04-28.at.12.18.09.AM.mov

What alternative solutions did you explore? (Optional)

no better solution i can think of

[MelvinBot]

📣 @chafikchaban! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

📣 @hellohublot You have been assigned to this job by @arosiclair!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[alexpensify]

PR is under review -- 👏🏼

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hellohublot got assigned: 2023-06-15 14:48:57 Z
• when the PR got merged: 2023-06-20 16:14:57 UTC
• days elapsed: 4

On to the next one 🚀

[alexpensify]

Awesome! Now, we are waiting for the automation to kick in here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide ReportActionContextMenu when ReportActionItem is destroyed #20890

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@dhanashree-sawant, @hellohublot, and @0xmiroslav please apply at https://www.upwork.com/jobs/~01522d777e8a7b8f13 and I can prepare for the pay period on 6/29. Thank you!

Also, @0xmiroslav please let me know if there are any required actions from me for the checklist. Thank you!

[dhanashree-sawant]

Hi @alexpensify, should I also apply for reporting bonus?

[alexpensify]

@dhanashree-sawant - yes please!

[dhanashree-sawant]

Thanks, I have applied.

[alexpensify]

Tomorrow is the payment date. @dhanashree-sawant, @hellohublot, and @0xmiroslav please apply at https://www.upwork.com/jobs/~01522d777e8a7b8f13 Thank you!

[dhanashree-sawant]

Thanks @alexpensify , if possible, can you send me invite to the job?

[alexpensify]

@dhanashree-sawant, @hellohublot, and @0xmiroslav - the proposals have been prepared in Upwork. Please accept and I can complete the payment. Thank you!

[dhanashree-sawant]

Thanks a lot! I have accepted the offer.

[0xmiros]

BZ checklist:
No regressions. This is rare case and so easily missed during initial implementation of popups on report action item.
I don't think it's worthy of adding regression test step.

[alexpensify]

Alright, @dhanashree-sawant, @hellohublot, and @0xmiroslav have been paid via Upwork. I've closed the job too, great work here!