Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-04-20 #17747

Closed
24 tasks done
OSBotify opened this issue Apr 20, 2023 · 9 comments
Closed
24 tasks done

Deploy Checklist: New Expensify 2023-04-20 #17747

OSBotify opened this issue Apr 20, 2023 · 9 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Apr 20, 2023

Release Version: 1.3.3-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 20, 2023
@mountiny mountiny added the Daily KSv2 label Apr 20, 2023
@mountiny mountiny self-assigned this Apr 20, 2023
@mountiny
Copy link
Contributor

Checking #16735 off this was tested before

@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.3-1 🚀

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.3-2 🚀

@mvtglobally
Copy link

mvtglobally commented Apr 21, 2023

@mountiny regression is almost completed

PR #16962 is failing #17787. Repro in prod, checking off
PR #17321 is failing #16946, older known issue
PR #17527 is failing #17786, not repro in prod
PR #17695 is failing #17789, not repro in prod

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.3-2 has been deployed to staging 🎉

@mountiny
Copy link
Contributor

checking off #17321 it was reverted

@mountiny
Copy link
Contributor

Checking #17695 off since the issue linked does not feel like a blocker

Only one PR left which is qaed internally

@mountiny
Copy link
Contributor

#15394 QA passed so I will be kicking off the deploy!

@mountiny
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants