Fix keyboard shortcut bugs on mobile

[luacmartins]

Problem

We are creating a new library that adds keyboard shortcuts functionality to mobile and since our current keyboard shortcut logic wasn't built for that, we uncovered 13 bugs when implementing the new feature. We should fix all of them

Why is this important

There are bugs that lead to broken functionality

Solution

Each of them will likely have it's own solution. We need to investigate and fix them!

[MelvinBot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[luacmartins]

@azimgd would you mind commenting on this issue so I can assign it to you?

[azimgd]

Sure!

[MelvinBot]

📣 @azimgd! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[parasharrajat]

I am happy to review it as well.

[abekkala]

Any update here?

[luacmartins]

We reverted the PR that introduced this functionality due to App Store Connect issues. So we'll have to wait until the ew PR gets merged to work on these bugs.

[luacmartins]

No updates yet. We reverted the initial PR and we are still waiting for the next one to be merged!

[luacmartins]

New PR got merged, we're waiting for it to hit prod before we can start on this.

[luacmartins]

PR is in prod. We can start working on this. @azimgd You expressed some concerns about the complexity/payout of Issues 1&2 below, but would you like to get started on issues 3-5? If so, I can create them to track it separately from the current issue.

Issue 1 - OptionsSelector

• iOS: SearchPage: Not able to scroll up in the list on the OptionList page(Search Page, newChat page, new Group Page)
• iOS: New Group Page Behaviour is buggy. When we Press enter on any item, sometimes it selects two items
• iOS: New Group Page: Try to unselect the last checked/selected item via Enter Key, deselects it, and reselect it
• Android: SearchPage: Pressing the arrow down jumps two items at once in the list. (Hard to reproduce). There is no exact reproduction. Every time it occurs differently
• Bug: Android: Long pressing arrow keys does not continuously navigate the list

Issue 2 - Form submission

• iOS | Android: DisplayNamePage: Clicking enter on the keyboard does not submit the form and close the page. (Applies to all pages which support pressing Enter to submit)
• Android mWeb Chrome | Android: Pressing Enter does not submit the message.

Issue 3 - Attachment modal

• iOS: Add attachment modal does not navigate based on arrow keys
• iOS | Android: Left & Right arrow keys does not work (seems to be duplicate of the issue above)

Issue 4 - Closing modals

• Android: Pressing ESC on SeachPage does not close it
• Android mWeb Chrome: iOS safari: Using the Escape key to close the attachment menu freezes the app

Issue 5 - Shortcut modal

• Android: The keyboard shortcut modal closes immediately after opening it.
• iOS Safari: iOS: [Inconsistency issue] Shortcuts to open the keyboard shortcut modal also closes it.

[azimgd]

@luacmartins I can start working on issues 3-5 tomorrow, as the 7 day prod regression period for the #6883 finishes on May 3rd. Could you please create a separate issue and assign me there?

[luacmartins]

@azimgd Great! I created the issues. Please comment on each so I can assign them to you:

• [HOLD for payment 2023-06-02] [$1000] Attachment modal shortcut bugs on native #18268
• [$1000] Closing modals shortcut bugs on native #18269
• [HOLD for payment 2023-05-16] [$1000] Shortcut modal shortcut bugs on native #18270

[luacmartins]

we're working on the separate issues linked above

[luacmartins]

working on separate issues linked above

[melvin-bot]

@azimgd @abekkala @luacmartins this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[luacmartins]

Workin on separate issues

[luacmartins]

I'm actually gonna close this one in favor of the individual issues.