[HOLD for payment 2023-06-01] [HOLD PR #18865][$1000] iOS / Safari - On long pressing "terms of service" link it gets completely hidden

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Navigate to Settings > Workspaces > Click on any workspace > Connect bank account > Continue with setup
3. Long press on Expensify Terms of Service
4. You'll notice that the link will not be visible

Expected Result :

The behaviour of should be similar to other links in the app.

Actual Result :

Link is getting hidden immediately

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.96-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

link.MP4

Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680775210239189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c45d4a2d89fd9ab
• Upwork Job ID: 1653184772719976448
• Last Price Increase: 2023-05-01

[MelvinBot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@anmurali Still overdue 6 days?! Let's take care of this!

[MelvinBot]

@anmurali 10 days overdue. Is anyone even seeing these? Hello?

[MelvinBot]

@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@anmurali 12 days overdue. Walking. Toward. The. Light...

[MelvinBot]

This issue has not been updated in over 14 days. @anmurali eroding to Weekly issue.

[MelvinBot]

@anmurali this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS / Safari - On long pressing "terms of service" link it gets completely hidden

What is the root cause of that problem?

Inside CheckboxWithLabel we are wrapping with Label with TouchableOpacity. There's an issue with TouchableOpacity on mWeb safari which preventing the safari preview functionality, with some background color or when you don't set background color for TouchableOpacity, when you tried to long press to preview, the callout menu will overlap the content, after you release the finger, the callout menu will need seconds to fully disappear that why you can see the link disappeared for a while after being long pressed.

App/src/components/CheckboxWithLabel.js

Lines 100 to 121 in 6fb0969

	<TouchableOpacity
	focusable={false}
	onPress={this.toggleCheckbox}
	activeOpacity={variables.checkboxLabelActiveOpacity}
	style={[
	styles.ml3,
	styles.pr2,
	styles.w100,
	styles.flexRow,
	styles.flexWrap,
	styles.flexShrink1,
	styles.alignItemsCenter,
	styles.noSelect,
	]}
	>
	{this.props.label && (
	<Text style={[styles.ml1]}>
	{this.props.label}
	</Text>
	)}
	{this.LabelComponent && (<this.LabelComponent />)}
	</TouchableOpacity>

Here's the evidence video about preview function with TouchableOpacity and Pressable in 3 cases:

• TouchableOpacity has backgroundColor that callout doesn't overlap the its content.
• TouchableOpacity doesn't have backgroundColor or has greenAppBackground color.
• Pressable

Screen.Recording.2023-04-27.at.17.22.35.mov

What changes do you think we should make in order to solve the problem?

We can replace current TouchableOpacity we are using to wrap the checkbox's label with Pressable.

App/src/components/CheckboxWithLabel.js

Lines 100 to 104 in 6fb0969

	<TouchableOpacity
	focusable={false}
	onPress={this.toggleCheckbox}
	activeOpacity={variables.checkboxLabelActiveOpacity}
	style={[

                    <Pressable
                        focusable={false}
                        onPress={this.toggleCheckbox}
                        style={({pressed}) => [
                            styles.ml3,
                            styles.pr2,
                            styles.w100,
                            styles.flexRow,
                            styles.flexWrap,
                            styles.flexShrink1,
                            styles.alignItemsCenter,
                            styles.noSelect,
+                            {opacity: pressed ? variables.checkboxLabelActiveOpacity : 1},
                        ]}
                    >
                        {this.props.label && (
                            <Text style={[styles.ml1]}>
                                {this.props.label}
                            </Text>
                        )}
                        {this.LabelComponent && (<this.LabelComponent />)}
                    </Pressable>

We can also use PressableWithFeedback to keep the activeOpacity behavior.

<PressableWithFeedback
  pressDimmingValue={variables.checkboxLabelActiveOpacity}
  hoverDimmingValue={1}
....otherProps
>
</PressableWithFeedback>

What alternative solutions did you explore? (Optional)

None

Result:

Screen.Recording.2023-04-27.at.17.34.30.mov

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~019c45d4a2d89fd9ab

[MelvinBot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: On long pressing terms of service link it gets completely hidden IOS/Safari #19101

If no regressions arise, payment will be issued on 2023-06-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@marcochavezf I couldn't pinpoint the issue for the offending PR. We've been using TouchableOpacity, since the time the component was added in this PR, but I think this wasn't an issue in the light theme. I think we got this issue when we moved to Dark theme. Also I don't think we need a regression test for this one as it is about long press and we've completely replaced the clickable component. Let me know if you think otherwise.

@anmurali this is ready for payout. Please note this PR introduced a regression on staging.

[marcochavezf]

Thanks @mananjadhav for the analysis. Yeah, I agree that we don't need a regression test here.

[mananjadhav]

@anmurali Quick bump on the payout for this one.

[mananjadhav]

@anmurali did you get a chance to look at the previous comment for the payout?

@marcochavezf if you could help.

[anmurali]

Paid!

[daraksha-dk]

@anmurali - I have applied to the job but have not received the reporting bonus, will you please check.

[daraksha-dk]

bump @kevinksullivan @anmurali

[kevinksullivan]

@daraksha-dk please apply to this job as the other one is closed, and I'll pay this out.

https://www.upwork.com/jobs/~0157c9d26f8cd9eead

Let me know when you've applied.

[daraksha-dk]

@kevinksullivan I have accepted the offer, thank you!

[kevinksullivan]

@daraksha-dk one more step since that was the application. I've sent the offer back to you. Let me know when you accept it.

[daraksha-dk]

Accepted now! Thanks once again 🚀

[kevinksullivan]

All set