[HOLD for payment 2023-04-07] Testing build link does not work for iOS

[luacmartins]

Problem

The testing build link for the iOS build does not work and shows the following error.

Why is this important

Sometime we want to provide the testing build so that contributors or Applause can test a release build on a specific PR. This error prevents testing and ensuring the code we are shipping has no bugs.

Solution

Something something iOS certificate

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018565b82a31952e3e
• Upwork Job ID: 1638628446550085632
• Last Price Increase: 2023-03-22

[MelvinBot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[isabelastisser]

Hey @luacmartins, this should be internal right?

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~018565b82a31952e3e

[luacmartins]

Correct! Added the label. Thanks for the ping :)

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[luacmartins]

No updates yet. I'll try to work on it this week.

[luacmartins]

No updates yet

[AndrewGable]

I went over this with @luacmartins and we are pretty sure this will be fixed by re-encrypting the adhoc provisioning profile. Let me know if you need help @luacmartins

[luacmartins]

Waiting for one of our contributors to send us their uuid. I'll then update the adhoc profile and try the solution above.

[AndrewGable]

PR 👉 #16675

[luacmartins]

@staszekscp Hey Mariusz! We are having issues with the iOS test build and would be curious for your thoughts. We update the adhoc profile to include our phones uuid, but that didn't seem to be enough. Any ideas why we see the message above on iOS?

[staszekscp]

@luacmartins You would have to merge main first to see if it works, because the previous certificate was used to build the app :)

[AndrewGable]

That makes sense, I was wondering if it was using the new profile or not

[staszekscp]

@AndrewGable Yep, the certificate is decrypted from a local file, so it has to be in the repo :)

[luacmartins]

Sounds good! I started a test build in this test PR. Hopefully it'll work this time :)

[luacmartins]

@staszekscp that worked! Thank you very much for the help!

[luacmartins]

Gonna close this issue since @AndrewGable PR solved it!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA]Add new adhoc profile with @parasharrajat #16675

If no regressions arise, payment will be issued on 2023-04-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt / @AndrewGable / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt / @AndrewGable / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt / @AndrewGable / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@isabelastisser] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

I think the checklist does not apply here.

[luacmartins]

Yea, we are good without the checklist!