Migrate ReportActionItem.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/home/report/ReportActionItem.js
  • type: React.Component
  • has state values: true
  • has refs: true
  • has context: false
  • lifecycle methods: componentDidUpdate,shouldComponentUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

[jasperhuangg]

@marcaaron Does this still need to be on HOLD?

[marcaaron]

We've already started so I think this can come off HOLD. But maybe we can wait for some more "official" word before continuing with the others.

The official word is just me posting an update somewhere soon saying that we should start looking into them 😄

[marcaaron]

@jasperhuangg taking this issue off HOLD as per this Slack post

IMPORTANT: If anything unexpected pops up during the refactor/review:

• Take it to #expensify-open-source to get clarification on.
• Prefix the conversation with [HOOK REFACTOR] so that we can find it easily.
• Link the result of the conversation in this section of the Design Doc titled “Best Practices Conversations”
• Add it to the STYLE.md guide in this open PR so we can reference it and apply any teachings in the next phase

[jasperhuangg]

We're still under review here

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[MelvinBot]

@jasperhuangg Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@jasperhuangg Still overdue 6 days?! Let's take care of this!

[MelvinBot]

@jasperhuangg Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MelvinBot]

@jasperhuangg 12 days overdue now... This issue's end is nigh!

[MelvinBot]

This issue has not been updated in over 14 days. @jasperhuangg eroding to Weekly issue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor ReportActionItem to use hooks #18809

If no regressions arise, payment will be issued on 2023-06-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty