[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$250] Migrate RequestorOnfidoStep.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/ReimbursementAccount/RequestorOnfidoStep.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0108c7eff871f84756
• Upwork Job ID: 1702336246230073344
• Last Price Increase: 2023-09-14

[s-alves10]

I'd love to work on this.

[neonbhai]

I can work on this!

[dhairyasenjaliya]

@neonbhai don't spam proposal on hold Gh try to find migration on unhold issues

[olexyt]

I can work on this issue.

[dhairyasenjaliya]

@olexyt do not spam on all issue and also this are on hold

[to-ai]

I am able to work on this task.

[pradeepmdk]

i will work on this

[barttom]

Hi! I'm Bartek from Callstack - an expert contributor group and I would like to work on this one.

[melvin-bot]

📣 @barttom! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[barttom]

Contributor details
Your Expensify account email: bartlomiej.tomczyk@callstack.com

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0108c7eff871f84756

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[ghost]

Dibs

[melvin-bot]

This issue has not been updated in over 15 days. @barttom, @sobitneupane, @jliexpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[jliexpensify]

This isn't overdue right? Also, is any payment from me needed? Sobit takes New.Dot and @barttom invoices us right?

[barttom]

Hey @jliexpensify!
This issue is on me, I just need to merge main branch into mine fetuje branch, but I’m on OOO until end of this week

[jliexpensify]

No worries! Thanks for letting us know. @barttom just to confirm that you invoice us for payment, correct?

[barttom]

@jliexpensify I’m a part of callstack team, so I afaik they are care of invoices 😉

[jliexpensify]

Hi @sobitneupane @barttom just checking: this hasn't been competed/implemented right?

[barttom]

@jliexpensify It has been merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactor: transformed class component to the functional #27424

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @barttom does not require payment (Contractor)
• @sobitneupane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactor: transformed class component to the functional #27424

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @barttom does not require payment (Contractor)
• @sobitneupane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Pujan92]

@barttom As it is still in the regression period, I found a console warning and reported here, #29868.

Reason: We switched to useLocalize and removed withLocalize but StepPropTypes expects a prop withLocalizePropTypes which is now missing.

[jliexpensify]

Payment Summary (due to regression)

• Contributor: @barttom $125 (Callstack invoiced payment)

NO UPWORKS JOB

[sobitneupane]

@jliexpensify I wasn't assigned to the PR, and I didn't review it. Therefore, no payment is due to me.

[jliexpensify]

Fixed, thanks for letting me know!