Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-10] [$250] Migrate Switch.js to function component #16204

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 41 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

  • src/components/Switch.js
    • type: React.Component
    • has state values: false
    • has refs: false
    • has context: false
    • lifecycle methods: componentDidUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a969618a599c1a97
  • Upwork Job ID: 1685092744716627968
  • Last Price Increase: 2023-07-29
  • Automatic offers:
    • s77rt | Reviewer | 25865423
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate Switch.js to function component [HOLD][$250] Migrate Switch.js to function component Apr 13, 2023
@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@dummy-1111
Copy link
Contributor

I'd love to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@vdem0115
Copy link

vdem0115 commented Jul 7, 2023

I would like to work on this issue.

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this?

@mejed-alkoutaini
Copy link

I'm able to work on this if needed!

@marcaaron marcaaron added NewFeature Something to build that is a new item. and removed Improvement Item broken or needs improvement. labels Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a969618a599c1a97

@marcaaron marcaaron changed the title [HOLD][$250] Migrate Switch.js to function component [$250] Migrate Switch.js to function component Jul 29, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 31, 2023

📣 @evappdev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@evappdev
Copy link

Contributor details
My Expensify account email: geetha@eventurers.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01c0c414c2f454c816

@s77rt
Copy link
Contributor

s77rt commented Jul 31, 2023

@evappdev Thanks for your interest here but @huzaifa-99 is already working on this.

@deetergp Please assign @huzaifa-99 here

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 31, 2023

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot
Copy link

melvin-bot bot commented Jul 31, 2023

📣 @huzaifa-99 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@huzaifa-99
Copy link
Contributor

PR is already merged melvin.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Aug 3, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate Switch.js to function component [HOLD for payment 2023-08-10] [$250] Migrate Switch.js to function component Aug 3, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@jliexpensify
Copy link
Contributor

Any checklist needed here @s77rt ?

@s77rt
Copy link
Contributor

s77rt commented Aug 4, 2023

@jliexpensify No, checklists are only for bugs. This is a functional migration (improvement/feature request).

@jliexpensify
Copy link
Contributor

Thought so, cheers!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 9, 2023
@jliexpensify
Copy link
Contributor

jliexpensify commented Aug 10, 2023

Payment Summary:

Upwork job

@huzaifa-99
Copy link
Contributor

@jliexpensify Does a bonus also apply on these issues?

@jliexpensify
Copy link
Contributor

@huzaifa-99 unfortunately not! The function component jobs are a flat $250.

@huzaifa-99
Copy link
Contributor

Thank you @jliexpensify. I have applied on upwork.

@jliexpensify
Copy link
Contributor

Everyone paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests