Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-28] [$250] Migrate Checkbox.js to function component #16123

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 17 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@marcaaron
Copy link
Contributor

Class Component Migration

Filenames

  • src/components/Checkbox.js
    • type: React.Component
    • has state values: true
    • has refs: true
    • has context: false
    • lifecycle methods: none

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate Checkbox.js to function component [HOLD][$250] Migrate Checkbox.js to function component Apr 13, 2023
@kuluruvineeth

This comment was marked as spam.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 29, 2023
@NikkiWines NikkiWines self-assigned this May 1, 2023
@NikkiWines NikkiWines removed the Daily KSv2 label May 1, 2023
@marcaaron
Copy link
Contributor Author

@kuluruvineeth Please stop spamming the issues in this repo. You are free to comment on things that have the Help Wanted label on them.

@kuluruvineeth
Copy link

@marcaaron my apologies, i was not aware that this issues were internal i learnt the same just a while ago. I shall make sure it won't happen again thanks.

@marcaaron
Copy link
Contributor Author

Yeah, there's not really any good reason to spam a bunch of issues with similar comments in any case. If you are not sure about something ask in Slack and we are happy to provide assistance there, thanks!

@marcaaron marcaaron added the Daily KSv2 label Jun 2, 2023
@marcaaron marcaaron changed the title [HOLD][$250] Migrate Checkbox.js to function component [$250] Migrate Checkbox.js to function component Jun 2, 2023
@marcaaron
Copy link
Contributor Author

Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

@NikkiWines
Copy link
Contributor

Nice, I'll push up a PR for this first thing monday

@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@kushu7
Copy link
Contributor

kushu7 commented Jun 5, 2023

I can work on this if it goes to external.

@NikkiWines
Copy link
Contributor

PR is up, working on testing

@melvin-bot melvin-bot bot removed the Overdue label Jun 6, 2023
@olexyt
Copy link
Contributor

olexyt commented Jun 7, 2023

I love to work on this issue

@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review and removed Overdue labels Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

@NikkiWines Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@NikkiWines
Copy link
Contributor

PR has been merged

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 21, 2023
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Jun 21, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate Checkbox.js to function component [HOLD for payment 2023-06-28] [$250] Migrate Checkbox.js to function component Jun 21, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 27, 2023
@NikkiWines
Copy link
Contributor

NikkiWines commented Jun 29, 2023

oh hmm looks like we need a BZ member to issue payment to @aimane-chnaif for reviewing #20193 - asking about the appropriate label now

@melvin-bot melvin-bot bot removed the Overdue label Jun 29, 2023
@NikkiWines
Copy link
Contributor

@greg-schroeder kindly volunteered to help out here 🙇

@greg-schroeder
Copy link
Contributor

created a job https://www.upwork.com/jobs/~014cc74cd0980ecb9b

sent you an offer for reviewing this @aimane-chnaif

@greg-schroeder
Copy link
Contributor

Pending acceptance and then we can close

@melvin-bot melvin-bot bot added the Overdue label Jul 3, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

6 participants