Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-01-25] IOU - White spaces appears in preview if spaces added in what's it for as optional message #14287

Closed
6 tasks
kavimuru opened this issue Jan 13, 2023 · 24 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Jan 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. go to any chat
  2. click on + icon and choose sent money and request money
  3. enter amount and click on next button
  4. type whitespaces in what’s it for textinput
  5. complete the process and check chat

Expected Result:

should not show whitespaces

Actual Result:

for sent money shows whitespaces and for request money whitespace appears for a seconds

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.53-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-01-13.at.12.30.11.PM.mov
Recording.1281.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673593293672519

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e3c4da93ade354fc
  • Upwork Job ID: 1613962659185745920
  • Last Price Increase: 2023-01-13
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 13, 2023

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 13, 2023
@luacmartins luacmartins self-assigned this Jan 13, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jan 13, 2023
@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label Jan 13, 2023
@melvin-bot melvin-bot bot unlocked this conversation Jan 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 13, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e3c4da93ade354fc

@melvin-bot
Copy link

melvin-bot bot commented Jan 13, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jan 18, 2023
@melvin-bot melvin-bot bot changed the title IOU - White spaces appears in preview if spaces added in what's it for as optional message [HOLD for payment 2023-01-25] IOU - White spaces appears in preview if spaces added in what's it for as optional message Jan 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 18, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.55-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-01-25. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Jan 18, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@mallenexpensify mallenexpensify added Daily KSv2 and removed Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jan 20, 2023
@luacmartins
Copy link
Contributor

Done with the first 3 items in the checklist. @sonialiap all yours for the last item!

@luacmartins
Copy link
Contributor

Still waiting on the regression period for payment!

@mollfpr
Copy link
Contributor

mollfpr commented Jan 25, 2023

Unassigning myself and @thesahindia should be assigned for the PR review, thanks!

@mollfpr mollfpr removed their assignment Jan 25, 2023
@thesahindia
Copy link
Member

@sonialiap, it's ready for payment.

@luacmartins
Copy link
Contributor

@sonialiap have we handled all payments for this issue? Can we close this?

@sonialiap
Copy link
Contributor

To confirm payments to:
@gadhiyamanan - for reporting
@thesahindia - for PR review
@mollfpr - for PR review

Is this correct?

@luacmartins
Copy link
Contributor

It should be:
@gadhiyamanan - for reporting
@thesahindia - for PR review

@mollfpr got assigned because I added the internal label too late and @thesahindia had already reviewed the PR.

@thesahindia
Copy link
Member

Bump @sonialiap ^

@luacmartins
Copy link
Contributor

Still waiting on payments

@thesahindia
Copy link
Member

Looks like @sonialiap is OOO @luacmartins

@luacmartins luacmartins added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 9, 2023
@MelvinBot

This comment was marked as outdated.

@MelvinBot

This comment was marked as off-topic.

@luacmartins
Copy link
Contributor

@mateocole Sonia is ooo, could you help with payment?

@mateocole
Copy link

looks like the old upwork job closed, can contributors apply here: https://www.upwork.com/jobs/~012706b583522bdff4

@gadhiyamanan
Copy link
Contributor

@mateocole applied

@thesahindia
Copy link
Member

Applied, thanks!

@mateocole
Copy link

Okay, contract sent!

@mateocole
Copy link

Okay all paid!

@gadhiyamanan
Copy link
Contributor

@mateocole please close the upwork contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

9 participants