Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD #11768] Screens are unmounting unnecessarily when navigating between them #14173

Closed
mountiny opened this issue Jan 10, 2023 · 6 comments
Closed

[HOLD #11768] Screens are unmounting unnecessarily when navigating between them #14173

mountiny opened this issue Jan 10, 2023 · 6 comments
Assignees
@JmillsExpensify @mountiny
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jan 10, 2023 •
edited
Loading

On hold for #11768

Problem

All navigations are kinda unmounting the previous screen, e.g. when navigating from Main -> Chat the contacts list flashes and disappears (probably incorrect usage of react-freeze) Slack

Why is it important

Bad UX and more resource demanding for the device

Solution

This is probably tied to react-freeze usage and it is a regression. This might get resolved by the navigation refactor so we gonna hold this on that issue.
@mountiny mountiny added the Monthly KSv2 label Jan 10, 2023
@mountiny mountiny self-assigned this Jan 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 10, 2023
@mountiny mountiny mentioned this issue Jan 10, 2023
Closed
7 tasks
@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 10, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Jan 10, 2023
@mountiny mountiny added Monthly KSv2 and removed Daily KSv2 labels Jan 10, 2023
@JmillsExpensify
Copy link

Thanks for creating the issue and also linking it in our doozy of a tracking issue!

@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Feb 13, 2023 •
edited
Loading

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 17, 2023
@mountiny
Copy link
Contributor Author

On hoold

@melvin-bot melvin-bot bot removed the Overdue label Mar 17, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@mountiny
Copy link
Contributor Author

on hold

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2023
@melvin-bot melvin-bot bot added the Overdue label May 19, 2023
@JmillsExpensify
Copy link

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2023
@mountiny
Copy link
Contributor Author

I believe this is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmillsExpensify JmillsExpensify

@mountiny mountiny

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JmillsExpensify @mountiny