Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-12-05] New Chat - "Recents" contacts are NOT correctly ordered by the latest messages #13072

Closed
kbecciv opened this issue Nov 27, 2022 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Nov 27, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log with any account which have a lot of contacts
  3. Go to New Chat or New Group
  4. Verify there are 5 conversations displayed in "Recents" and that they are correctly ordered by the latest message

Expected Result:

Contacts should be correctly ordered by the latest messages in the "Recent" section

Actual Result:

"Recents" contacts are NOT correctly ordered by the latest messages

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Desktop App
  • Mobile Web

Version Number: 1.2.32.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (2)

Bug5838294_Recording__3097.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 27, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2022

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@s77rt
Copy link
Contributor

s77rt commented Nov 27, 2022

Unable to reproduce from my side

@mountiny
Copy link
Contributor

I also cannot reproduce after a fresh sign in in production or in staging 🤷
image

@mvtglobally
Copy link

asking team to double check

@luacmartins
Copy link
Contributor

I'm also unable to reproduce
Screenshot 2022-11-28 at 10 09 56 AM

@luacmartins
Copy link
Contributor

@mvtglobally were you able to reproduce the issue?

@mvtglobally
Copy link

@luacmartins Team is still able to repro with High traffic account

Recording.1793.mp4

@mountiny
Copy link
Contributor

This would have to be related to this PR, however, with the migration there, I am not sure if reverting would be best option.

Given the nature of this bug and the fact the PR is part of a broader initiative to fix way worse issue, I would vote for treating this as Bug but not as a deploy blocker

@luacmartins
Copy link
Contributor

Fix here

@luacmartins luacmartins added the Reviewing Has a PR in review label Nov 28, 2022
@luacmartins
Copy link
Contributor

Closing this issue since the PR was merged!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Nov 28, 2022
@melvin-bot melvin-bot bot changed the title New Chat - "Recents" contacts are NOT correctly ordered by the latest messages [HOLD for payment 2022-12-05] New Chat - "Recents" contacts are NOT correctly ordered by the latest messages Nov 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 28, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.32-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-05. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants