[HOLD for payment 2022-11-29] [$1000] App crashes when create new chat with the contact who has deprecated pronoun - reported by @aimane-chnaif

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account
2. Click FAB icon -> New chat
3. Enter kbecciv+1031abb2@gmail.com (has deprecated pronoun - Ze/hir) and select that contact

Expected Result:

New chat created with that user

Actual Result:

App crashes

Workaround:

None (well, get the person to change their pronouns presumably)

Platform:

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.2.28-2 (reproducible in dev only but will be deploy blocker soon)
Reproducible in staging?: N
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

crash.mp4

Regression from this PR CC: @Beamanator

Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668625056676409

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @neil-marcellini (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

Based on this discussion, @aimane-chnaif want to add your proposal here so we can keep this moving before it gets to staging and becomes a deploy blocker?

[aimane-chnaif]

Proposal

This is a regression from #12301.
zeHirHirs pronoun is removed while new pronouns are added, so we need to add it back

https://github.com/Expensify/App/blob/main/src/languages/en.js

    pronouns: {
        coCos: 'Co / Cos',
        eEyEmEir: 'E / Ey / Em / Eir',
        faeFaer: 'Fae / Faer',
        heHimHis: 'He / Him / His',
        sheHerHers: 'She / Her / Hers',
        merMers: 'Mer / Mers',
        neNirNirs: 'Ne / Nir / Nirs',
        neeNerNers: 'Nee / Ner / Ners',
        perPers: 'Per / Pers',
        theyThemTheirs: 'They / Them / Theirs',
        thonThons: 'Thon / Thons',
        veVerVis: 'Ve / Ver / Vis',
        viVir: 'Vi / Vir',
        xeXemXyr: 'Xe / Xem / Xyr',
        zeZieZirHir: 'Ze / Zie / Zir / Hir',
+       zeHirHirs: 'Ze / hir',
        callMeByMyName: 'Call me by my name',
    },

Same applies to https://github.com/Expensify/App/blob/main/src/languages/es.js

[AndrewGable]

Can you add a space? Otherwise yes this looks good: zeHirHirs: 'Ze / hir',

[aimane-chnaif]

Can you add a space? Otherwise yes this looks good: zeHirHirs: 'Ze / hir',

sure, updated proposal

[Beamanator]

Agreed & Let's capitalize Hir but I'd say we're ready for PR 👍

[melvin-bot]

📣 @aimane-chnaif You have been assigned to this job by @AndrewGable!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[trjExpensify]

Neat! @aimane-chnaif can we get a the PR up and merged for this right away today? Happy to increase the bounty to $1k if we can.

[aimane-chnaif]

@AndrewGable PR is ready for review

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• @trjExpensify A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
• @mollfpr @aimane-chnaif @AndrewGable The PR that introduced the bug has been identified. Link to the PR: New Pronouns page #12301
• @trjExpensify The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A - @Beamanator the author is aware and part of the discussion when this regression was caught.
• @trjExpensify A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• @trjExpensify Payment has been made to the issue reporter (if applicable)
• @trjExpensify Payment has been made to the contributor that fixed the issue (if applicable)
• @trjExpensify Payment has been made to the contributor+ that helped on the issue (if applicable) - N/A we merged this one immediately as a breaking change before becoming a deploy blocker.

[melvin-bot]

@AndrewGable, @trjExpensify, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[AndrewGable]

Not overdue

[trjExpensify]

Alrighty, ready to pay this one out @aimane-chnaif. We quick stepped it, so there wasn't a job for it. Just sent you a contract to accept on Upwork.

[trjExpensify]

Cool, paid! 🎉