Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-12-07] Update New Dot Colors #12440

Closed
Luke9389 opened this issue Nov 3, 2022 · 19 comments
Closed

[HOLD for payment 2022-12-07] Update New Dot Colors #12440

Luke9389 opened this issue Nov 3, 2022 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@Luke9389
Copy link
Contributor

Luke9389 commented Nov 3, 2022

Tracking Issue: #12251
Design Doc Section: https://docs.google.com/document/d/197fXHLlHM_RJA4-3MITwdu0N5e0HX5Q74sA4W80YMD8/edit#bookmark=id.zh5fku1wwmp2

Color Swaps

Here’s a list of color values that will change:
App Background: #FFFFFF → #061B09
Highlight Background: #FAFAFA → #002E22
Borders: #ECECEC → #1B5744
Icons: #C6C9CA → #8B9C8F
Supporting Text: #7D8B8F → #C9D3C5
Text: ##0B1B34 → #FFFFFF
Danger (Red): #FC3826 → #FC3826
Default Button Text: #0B1B34 → #FFFFFF
Danger Button BG: #FC3826 → #FC3826
Link Color: #0185FF → #8DC8FF

All of these colors are currently stored in a file called colors.js. Each of the current values in that file will be switched according to the scheme above.

Ghost UI

We also need to change the colors on the loading Ghost UI.
Screen Shot 2022-11-03 at 12 05 25 PM

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0103cf97848a39b3c9
  • Upwork Job ID: 1606463587928702976
  • Last Price Increase: 2022-12-24
@Luke9389 Luke9389 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 3, 2022
@Luke9389 Luke9389 removed the Bug Something is broken. Auto assigns a BugZero manager. label Nov 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 3, 2022

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Luke9389 Luke9389 assigned grgia and unassigned Christinadobrzyn Nov 3, 2022
@Luke9389
Copy link
Contributor Author

Luke9389 commented Nov 3, 2022

Sorry for the noise @Christinadobrzyn, this is not a Bug :)

@melvin-bot
Copy link

melvin-bot bot commented Nov 3, 2022

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

@Luke9389 Luke9389 removed the Design label Nov 3, 2022
@Luke9389 Luke9389 added Weekly KSv2 Improvement Item broken or needs improvement. and removed Daily KSv2 labels Nov 3, 2022
@Luke9389 Luke9389 changed the title Update Site Colors Update New Dot Colors Nov 3, 2022
@shawnborton
Copy link
Contributor

Hey @grgia for link color, let's try bumping them up just a shade darker. So that goes us:

Link: #5AB0FF
Link Hover: #8DC8FF

@shawnborton
Copy link
Contributor

How is progress going on this one? Can you provide an update @grgia @Luke9389? Thanks!

@grgia
Copy link
Contributor

grgia commented Nov 14, 2022

The colors are pretty much done right now, I'll likely need to merge main and do some final tweaking when everything is ready and we decide to merge in all the core branding.

@shawnborton
Copy link
Contributor

Sounds great. Do you have an ETA for when you'll be done with the final tweaking?

@grgia
Copy link
Contributor

grgia commented Nov 15, 2022

It can be done today if needed!

@shawnborton
Copy link
Contributor

Sounds good. Maybe we can shoot to have everything merged early next week, like on Monday? That would give us the rest of the week to wrap things up, cc @Luke9389

I'll post a weekly update today and we can discuss these things further though.

@grgia grgia mentioned this issue Nov 22, 2022
100 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 30, 2022
@melvin-bot melvin-bot bot changed the title Update New Dot Colors [HOLD for payment 2022-12-07] Update New Dot Colors Nov 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 30, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.33-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-07. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Dec 23, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 23, 2022

This issue has not been updated in over 15 days. @parasharrajat, @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@grgia
Copy link
Contributor

grgia commented Dec 23, 2022

Are we good to close this out?

@shawnborton
Copy link
Contributor

Yeah, I think we're in a good spot now with colors. Thanks for all of the work getting these changes implemented, the app looks great ✨

@shawnborton
Copy link
Contributor

shawnborton commented Dec 23, 2022

Err actually, just want to confirm that we're all good with payments first?

@shawnborton shawnborton reopened this Dec 23, 2022
@mallenexpensify mallenexpensify self-assigned this Dec 24, 2022
@mallenexpensify mallenexpensify added the Internal Requires API changes or must be handled by Expensify staff label Dec 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 24, 2022

Job added to Upwork: https://www.upwork.com/jobs/~0103cf97848a39b3c9

@melvin-bot
Copy link

melvin-bot bot commented Dec 24, 2022

Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new.

@mallenexpensify
Copy link
Contributor

@parasharrajat , I believe you're do $1000, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0103cf97848a39b3c9

@mallenexpensify mallenexpensify added Daily KSv2 and removed Monthly KSv2 labels Dec 24, 2022
@parasharrajat
Copy link
Member

@mallenexpensify Accepted.

@mallenexpensify
Copy link
Contributor

Paid @parasharrajat $1000, thanks.
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants