-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-12-07] Update New Dot Colors #12440
Comments
Triggered auto assignment to @Christinadobrzyn ( |
Sorry for the noise @Christinadobrzyn, this is not a Bug :) |
Triggered auto assignment to @shawnborton ( |
Hey @grgia for link color, let's try bumping them up just a shade darker. So that goes us: Link: #5AB0FF |
The colors are pretty much done right now, I'll likely need to merge main and do some final tweaking when everything is ready and we decide to merge in all the core branding. |
Sounds great. Do you have an ETA for when you'll be done with the final tweaking? |
It can be done today if needed! |
Sounds good. Maybe we can shoot to have everything merged early next week, like on Monday? That would give us the rest of the week to wrap things up, cc @Luke9389 I'll post a weekly update today and we can discuss these things further though. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.33-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-12-07. 🎊 After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
This issue has not been updated in over 15 days. @parasharrajat, @grgia eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Are we good to close this out? |
Yeah, I think we're in a good spot now with colors. Thanks for all of the work getting these changes implemented, the app looks great ✨ |
Err actually, just want to confirm that we're all good with payments first? |
Job added to Upwork: https://www.upwork.com/jobs/~0103cf97848a39b3c9 |
Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new. |
@parasharrajat , I believe you're do $1000, can you please accept the job and reply here once you have? |
@mallenexpensify Accepted. |
Paid @parasharrajat $1000, thanks. |
Tracking Issue: #12251
Design Doc Section: https://docs.google.com/document/d/197fXHLlHM_RJA4-3MITwdu0N5e0HX5Q74sA4W80YMD8/edit#bookmark=id.zh5fku1wwmp2
Color Swaps
Here’s a list of color values that will change:
App Background: #FFFFFF → #061B09
Highlight Background: #FAFAFA → #002E22
Borders: #ECECEC → #1B5744
Icons: #C6C9CA → #8B9C8F
Supporting Text: #7D8B8F → #C9D3C5
Text: ##0B1B34 → #FFFFFF
Danger (Red): #FC3826 → #FC3826
Default Button Text: #0B1B34 → #FFFFFF
Danger Button BG: #FC3826 → #FC3826
Link Color: #0185FF → #8DC8FF
All of these colors are currently stored in a file called colors.js. Each of the current values in that file will be switched according to the scheme above.
Ghost UI
We also need to change the colors on the loading Ghost UI.
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: