[HOLD for payment 2022-11-29] [N7 Account Settings] Create Pronouns page

[Beamanator]

Tracking issue: https://github.com/Expensify/Expensify/issues/182122

Detailed section of doc here: https://docs.google.com/document/d/17akqrbC-w8FqEoDLvcLmrX6iw4uaVrT_xlwAl-IhEzE/edit#heading=h.5n8w70bpe690

Note: This can only be implemented after UpdatePronouns command has been built - see https://github.com/Expensify/Expensify/issues/238724

[Beamanator]

On hold for WhatsApp Quality

[Beamanator]

Still on hold for now, might pick this up next week as discussions from here (#11795) are indicating this could be useful to implement sooner rather than later

[Beamanator]

Still on hold, need to discuss if the dropdown should be push-to-page to be consistent with other dropdowns (like new timezone selector)

[Beamanator]

Agreed here that we're going with the current design of the Pronouns page in the doc:

we will continue to support dropdowns in the case of lists that exists within a grouped set of fields.

[Beamanator]

FYI we now may go with the current Pronouns design & open a new, separate project for redesigning the page & deciding what kind of "custom pronoun selector / creator" we want to implement (discussion)

[Beamanator]

Latest, agreed-upon plan is here: https://expensify.slack.com/archives/C01GTK53T8Q/p1668468842096049?thread_ts=1666881832.702589&cid=C01GTK53T8Q

[thesahindia]

@Beamanator, C+ compensation is pending on this one.

[melvin-bot]

Triggered auto assignment to @mateocole (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Beamanator]

Hey @mateocole can you pay out @thesahindia for his work reviewing the related internal PR? 👍

[Beamanator]

(reopening till payment has been completed)

[mateocole]

hey @Beamanator from reading the S/O is there an upwork associated with the PR review? it looks like i need to make sure i pay through that

[thesahindia]

hey @Beamanator from reading the S/O is there an upwork associated with the PR review

We will need to create one (no job right now)

If I am not wrong we just need to add external label and melvin will post the upwork job link on this issue.

[Beamanator]

@mateocole yes as you mentioned, we'll need an Upwork job for this. And interesting point @thesahindia , I know that automation is new, I don't necessarily like the idea of needing to add External label since this will also assign a C+ (which isn't needed for this issue) right? I'll ask internally, I think since all of this is new we'll eventually come up with better automation for this exact case :D

[thesahindia]

Yeah, makes sense!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.29-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• New Pronouns page #12301

If no regressions arise, payment will be issued on 2022-11-29. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[thesahindia]

Bump @mateocole for upwork

[mateocole]

Okay here is the job!
https://www.upwork.com/ab/applicants/1598482099900215296/job-details

[thesahindia]

@mateocole, I have applied and increased the job price since compensation for internal PR review is $1000 (slack post, please see the 4th point)

[Beamanator]

Hmm it looks like @thesahindia you reviewed on Nov 15 (here) but the update to increase C+ bounty to $1000 was made on Nov 18... I'll leave it up to @mateocole / @michaelhaxhiu to decide, I'm just pointing out date diff :D

[thesahindia]

Oh correct, I didn't check the date 😅

[mateocole]

Hey @thesahindia, would you be able to withdraw the proposal at the current rate, and go back to the Nov 15 rate?

[thesahindia]

@mateocole, I have changed the terms.

[mateocole]

Okay, offer sent!

[thesahindia]

Accepted, thanks!

[mateocole]

Okay, payment sent!