Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Attempt to edit a comment crashes the app - Reported by @adeel0202 #11301

Closed
mvtglobally opened this issue Sep 26, 2022 · 19 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. Send a message
  3. Long press the message
  4. Press Edit comment

Expected Result:

Able to edit the comment

Actual Result:

app crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.7-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

22-09-27-01-33-27.mp4

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1664224827873869

View all open jobs on GitHub

@mvtglobally mvtglobally added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Sep 26, 2022
@mvtglobally mvtglobally self-assigned this Sep 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@adeel0202
Copy link
Contributor

Hi @marcaaron, I think I'm eligible for the reporting bonus here.

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Sep 27, 2022

Am I also eligible for compensation? Since the issue was critical and urgent, and I found out the RCA and related PR immediately in slack thread.
#11256 (comment)

@adeel0202
Copy link
Contributor

Hi @marcaaron, I think I'm eligible for the reporting bonus here.

bump @marcaaron

@marcaaron
Copy link
Contributor

I'm not entirely sure. You will have to ask in Slack about this.

Thanks so much for reporting!

@mountiny mountiny added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2022

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2022

Current assignee @marcaaron is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title Android - Attempt to edit a comment crashes the app - Reported by @adeel0202 [$250] Android - Attempt to edit a comment crashes the app - Reported by @adeel0202 Sep 29, 2022
@mountiny
Copy link
Contributor

Sorry for the ping, @dylanexpensify Can you please pay @adeel0202 out a reporting bonus for this issue? Thank you very much!

@mountiny mountiny reopened this Sep 29, 2022
@adeel0202
Copy link
Contributor

Thank you @mountiny :)

@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2022

📣 @aimane-chnaif You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny
Copy link
Contributor

@dylanexpensify Can you additionally also pay out $250 to @aimane-chnaif for their help with finding the root cause for this deploy blocker and acting so fast for urgent issue? Thank you very much

Slack thread for context https://expensify.slack.com/archives/C01GTK53T8Q/p1664224827873869

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

@marcaaron, @dylanexpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2022
@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2022

Dylan is OOO, asking someone to handle the payments, thank you for patience

@michaelhaxhiu
Copy link
Contributor

Stepping in to help move this to completion.

Upwork job - https://www.upwork.com/jobs/~01dfc0368aadcc8d4f

@aimane-chnaif and @adeel0202 please accept my job invite in Upwork, you both should've received an email.

@adeel0202
Copy link
Contributor

Accepted, thanks.

@michaelhaxhiu
Copy link
Contributor

@adeel0202 is paid ✅

Just waiting on @aimane-chnaif next ⏳

@michaelhaxhiu
Copy link
Contributor

Both paid, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

9 participants