Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile - The photo with a gray background does not appear #10703

Closed
kavimuru opened this issue Aug 30, 2022 · 3 comments
Closed

Profile - The photo with a gray background does not appear #10703

kavimuru opened this issue Aug 30, 2022 · 3 comments
Assignees

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #10235

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Click on the avatar picker and upload an avatar
  3. Be ready to turn off your device wifi very quickly, click on the avatar picker and upload an avatar, but IMMEDIATELY turn off your device WiFi before avatar can finish uploading.

Expected Result:

The avatar should become grayed out if the Internet connection is turned off during loading

Actual Result:

The photo with a gray background does not appear

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.94-4

Reproducible in staging?: Y

Reproducible in production?: N (New feature)

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5711119_Recording__1710.mp4
Bug5711119_Recording__1712__2_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause internal team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2022

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jasperhuangg
Copy link
Contributor

Taking a look since this was related to my PR

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Aug 31, 2022

So I think in the OP they're not actually turning off the device wifi fast enough, you need to do it within a half second otherwise the upload will complete:

(I've set up the inspector to throttle the connection to "Offline" as soon as I open it, so opening the inspector below is the same as disabling device wifi)

Screen.Recording.2022-08-31.at.3.04.54.PM.mp4

Closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants