From 49be6ddcd3cc4073eacf6967ddf1cb480a5dfd19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanno=20J=2E=20G=C3=B6decke?= Date: Fri, 25 Aug 2023 18:36:04 +0200 Subject: [PATCH 1/2] make sure composer is always rendered --- .../report/ReportActionCompose/ComposerWithSuggestions.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js index 9f6d3cdac768..4d7a4c43d5e7 100644 --- a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js +++ b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js @@ -545,6 +545,9 @@ export default compose( withOnyx({ numberOfLines: { key: ({reportID}) => `${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT_NUMBER_OF_LINES}${reportID}`, + // We might don't have number of lines in onyx yet, for which the composer would be rendered as null + // for the first render, which we want to avoid: + initWithStoredValues: false, }, modal: { key: ONYXKEYS.MODAL, @@ -556,6 +559,7 @@ export default compose( parentReportActions: { key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`, canEvict: false, + initWithStoredValues: false, }, }), )( From a66bcbf7024e739a372c43790ee4dab0a88b360e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hanno=20J=2E=20G=C3=B6decke?= Date: Fri, 25 Aug 2023 20:35:19 +0200 Subject: [PATCH 2/2] Update src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com> --- .../report/ReportActionCompose/ComposerWithSuggestions.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js index 4d7a4c43d5e7..fdaf3cb6d80d 100644 --- a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js +++ b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js @@ -545,8 +545,8 @@ export default compose( withOnyx({ numberOfLines: { key: ({reportID}) => `${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT_NUMBER_OF_LINES}${reportID}`, - // We might don't have number of lines in onyx yet, for which the composer would be rendered as null - // for the first render, which we want to avoid: + // We might not have number of lines in onyx yet, for which the composer would be rendered as null + // during the first render, which we want to avoid: initWithStoredValues: false, }, modal: {