From 7986a7b8eee34f3936d3c9bc28747b6a4f43c455 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Tue, 13 Aug 2024 17:35:52 +0800 Subject: [PATCH] fix 0 is shown --- .../MoneyRequestPreviewContent.tsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx b/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx index 12065c4209db..8597654576fc 100644 --- a/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx +++ b/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx @@ -269,9 +269,10 @@ function MoneyRequestPreviewContent({ // If available, retrieve the split share from the splits object of the transaction, if not, display an even share. const splitShare = useMemo( () => - shouldShowSplitShare && - (transaction?.comment?.splits?.find((split) => split.accountID === sessionAccountID)?.amount ?? - IOUUtils.calculateAmount(isPolicyExpenseChat ? 1 : participantAccountIDs.length - 1, requestAmount, requestCurrency ?? '', action.actorAccountID === sessionAccountID)), + shouldShowSplitShare + ? transaction?.comment?.splits?.find((split) => split.accountID === sessionAccountID)?.amount ?? + IOUUtils.calculateAmount(isPolicyExpenseChat ? 1 : participantAccountIDs.length - 1, requestAmount, requestCurrency ?? '', action.actorAccountID === sessionAccountID) + : 0, [shouldShowSplitShare, isPolicyExpenseChat, action.actorAccountID, participantAccountIDs.length, transaction?.comment?.splits, requestAmount, requestCurrency, sessionAccountID], ); @@ -387,9 +388,9 @@ function MoneyRequestPreviewContent({ {merchantOrDescription} )} - {splitShare && ( + {!!splitShare && ( - {translate('iou.yourSplit', {amount: CurrencyUtils.convertToDisplayString(splitShare ?? 0, requestCurrency)})} + {translate('iou.yourSplit', {amount: CurrencyUtils.convertToDisplayString(splitShare, requestCurrency)})} )}