Merge pull request #28857 from namhihi237/fix-28825-copy-slice-persis…

…tedRequests [CP Staging] fix persisted request
Expensify · Oct 4, 2023 · 09ea179 · 09ea179
2 parents 4641d1b + b7d8299
commit 09ea179
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/src/libs/actions/PersistedRequests.ts b/src/libs/actions/PersistedRequests.ts
@@ -18,12 +18,14 @@ function clear() {
 }
 
 function save(requestsToPersist: Request[]) {
+    let requests: Request[] = [];
     if (persistedRequests.length) {
-        persistedRequests = persistedRequests.concat(requestsToPersist);
+        requests = persistedRequests.concat(requestsToPersist);
     } else {
-        persistedRequests = requestsToPersist;
+        requests = requestsToPersist;
     }
-    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests);
+    persistedRequests = requests;
+    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests);
 }
 
 function remove(requestToRemove: Request) {
@@ -35,13 +37,17 @@ function remove(requestToRemove: Request) {
     if (index === -1) {
         return;
     }
-    persistedRequests.splice(index, 1);
-    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests);
+    const requests = [...persistedRequests];
+    requests.splice(index, 1);
+    persistedRequests = requests;
+    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests);
 }
 
 function update(oldRequestIndex: number, newRequest: Request) {
-    persistedRequests.splice(oldRequestIndex, 1, newRequest);
-    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests);
+    const requests = [...persistedRequests];
+    requests.splice(oldRequestIndex, 1, newRequest);
+    persistedRequests = requests;
+    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests);
 }
 
 function getAll(): Request[] {