Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom labels fail when an XML element does not exist #4

Closed
Otterfan opened this issue Apr 1, 2019 · 1 comment
Closed

Custom labels fail when an XML element does not exist #4

Otterfan opened this issue Apr 1, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Otterfan
Copy link
Contributor

Otterfan commented Apr 1, 2019

Current behavior

Custom labels fail if the elements required to build that label don't exist. For example, a label like

<title>
<author>

Will fail if the item does not have an <author>, which is not uncommon.

Expected behavior

Either of the following:

  • Missing elements should not trigger an error at all.
  • Missing elements should trigger an error that can be suppressed if the field is prefixed with the asterisk (*) operator. The asterisk currently suppresses elements only if the element is blank but not if it is not present.
@Otterfan Otterfan added the bug Something isn't working label Apr 1, 2019
@Otterfan Otterfan changed the title Don Custom labels fail when an XML element does not exist Apr 1, 2019
@mgobat mgobat self-assigned this Jul 8, 2020
@mgobat
Copy link
Collaborator

mgobat commented Jul 13, 2020

Repaired for next release: if the field is prefixed with the asterisk (*) operator and the field is missing, the error is suppressed. Existing asterisk (*) operator functionality maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants