Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring empty datasets #189

Open
tmichela opened this issue May 27, 2021 · 1 comment · May be fixed by #192
Open

Ignoring empty datasets #189

tmichela opened this issue May 27, 2021 · 1 comment · May be fixed by #192

Comments

@tmichela
Copy link
Member

As highlighted by #187, there are files containing index for certain data sources, but with empty datasets.

Currently reading a selection of data sources containing one of these would fail reading data.
Should we skip these sources when datasets have exactly zero entries instead of raising an exception?
@takluyver
Copy link
Member

We could also catch the exception for any method which returns data from multiple datasets and exclude that key (as if it had a valid index but no data).

@tmichela tmichela linked a pull request Jun 9, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip empty datasets European-XFEL/EXtra-data
2 participants
@takluyver @tmichela