Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-ups open off screen on laptop and mobile devices #35

Open
karmstro77 opened this issue Sep 29, 2015 · 8 comments
Open

Pop-ups open off screen on laptop and mobile devices #35

karmstro77 opened this issue Sep 29, 2015 · 8 comments
Assignees
Labels

Comments

@karmstro77
Copy link

image

@MikeMillerGIS MikeMillerGIS self-assigned this Sep 29, 2015
@NikkiGolding
Copy link

NikkiGolding commented Oct 3, 2017

@MikeMillerGIS Is this a core Popup issue or is it tied to Information Lookup specifically? If it is the later, can we get this resolved soon? @previnWong

@MikeMillerGIS
Copy link
Member

We center the map and show pop up, map does not move itself. maybe there is a setting or something?

Can they use the side panel?

@MikeMillerGIS
Copy link
Member

maybe something we can leverage in this thread
https://community.esri.com/thread/32141

@previnWong
Copy link
Contributor

previnWong commented Oct 13, 2017

@karmstro77 @NikkiGolding Made a fix to center the popup to support mobile platform. By doing so, though, the point clicked is offset from center in the display. Give it a shot and let me know. Get the version in the dev branch.

https://github.com/Esri/information-lookup/tree/dev

@MikeMillerGIS
Copy link
Member

@previnWong We should make this an option. Will this change will affect and provide a different UX from an app today?

@previnWong
Copy link
Contributor

It shouldn't. Today, the map center and zooms to where the user clicked. The infowindow then opens and is offset to the right, therefore getting cut off on mobile devices.
image

Now, I just get where the user clicked, offset that location by the resolution of the infowindow. Then show the popup. The result is that the popup is centered in the viewing area and the clicked point is offset. A graphic is there so a user knows where he/she clicked.
image

@MikeMillerGIS
Copy link
Member

more worried about desktop browser based, will it only move the map if the pop up is cut off?

@previnWong
Copy link
Contributor

previnWong commented Oct 13, 2017

The existing code in there calls for the map to center and zoom. So the map in the desktop browser will move as of today. I'm just changing it slightly where it centers. It should do the same for desktop browser, push it away from top or right from getting cut off.

Speaking of it now, I haven't done the case where you click and select the underlying feature. I will have to handle that case as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants