Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert] Refactor register event #9499

Closed
1 of 5 tasks
geospatialem opened this issue Jun 3, 2024 · 5 comments
Closed
1 of 5 tasks

[Alert] Refactor register event #9499

geospatialem opened this issue Jun 3, 2024 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-alert Issues that pertain to the calcite-alert component calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-08-27 - Aug ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Jun 3, 2024 •
edited
Loading

Description

Refactor the current dispatchEvent to have a register of elements. Can be coupled with the effort of #9340

Proposed Advantages

Updated pattern and consistency across the design system

Which Component

alert

Relevant Info

calcite-design-system/packages/calcite-components/src/components/alert/alert.tsx

Line 197 in 570529f

window.dispatchEvent(

calcite-design-system/packages/calcite-components/src/components/alert/alert.tsx

Line 359 in 570529f

window.dispatchEvent(

Related to epic #7200

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@geospatialem geospatialem added refactor Issues tied to code that needs to be significantly reworked. p - low Issue is non core or affecting less that 10% of people using the library 0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jun 3, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Jun 3, 2024
@geospatialem geospatialem mentioned this issue Jun 3, 2024
Open
7 tasks
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 3, 2024
@geospatialem geospatialem added this to the 2024-12-17 - Dec Release milestone Jun 3, 2024
@driskull driskull mentioned this issue Aug 9, 2024
Merged
@driskull
Copy link
Member

driskull commented Aug 9, 2024

Seems like this is a duplicate of #9340

@driskull driskull assigned driskull and unassigned driskull Aug 9, 2024
@geospatialem
Copy link
Member Author

Seems like this is a duplicate of #9340

@driskull They seem separate to me, but we can combine them into one. Is #9340 the preferred issue for tracking? If so I can add the context above into the effort and move it to December closing out the above.

@driskull
Copy link
Member

Reading them again, they are separate but they can be tackled at the same time. 👍

@geospatialem geospatialem added the c-alert Issues that pertain to the calcite-alert component label Aug 12, 2024
@geospatialem geospatialem mentioned this issue Aug 12, 2024
Closed
6 tasks
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 12, 2024
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Aug 19, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Aug 20, 2024

🍠 Verified

@DitwanP DitwanP closed this as completed Aug 20, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-alert Issues that pertain to the calcite-alert component calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
4 participants
@jcfranco @driskull @geospatialem @DitwanP