Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree: update selection affordance in ancestors mode #8227

Closed
2 of 6 tasks
ashetland opened this issue Nov 21, 2023 · 3 comments
Closed
2 of 6 tasks

Tree: update selection affordance in ancestors mode #8227

ashetland opened this issue Nov 21, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-tree Issues that pertain to the calcite-tree and related components Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Milestone
2024-08-27 - Aug ...

Comments

@ashetland
Copy link
Contributor

Check existing issues

Description

Update Tree selection-mode="ancestors" to use icons instead of checkboxes. This will visually align Tree with updates from epic #7181.

Acceptance Criteria

Selection icons and hover states updated to match Figma designs.

Relevant Info

@geospatialem @brittneytewks These designs were originally included on a related, but separate issue. Logging this new one for inclusion in epic #7181.

Which Component

Tree, Tree Item

Example Use Case

No response

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 21, 2023
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Nov 21, 2023
@ashetland ashetland mentioned this issue Nov 21, 2023
Open
@ashetland ashetland added p - medium Issue is non core or affecting less that 60% of people using the library design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Nov 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added the c-tree Issues that pertain to the calcite-tree and related components label Nov 21, 2023
@geospatialem geospatialem added this to the 2024 April Priorities milestone Nov 22, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 22, 2023
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@aPreciado88 aPreciado88 self-assigned this Aug 8, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 13, 2024
@geospatialem
Copy link
Member

The above was included in PR #9849, where the following was added to the tree-item:

calcite-design-system/packages/calcite-components/src/components/tree-item/tree-item.tsx

Lines 235 to 245 in f2aa976

<calcite-icon
class={CSS.checkbox}
icon={
this.selected
? ICONS.checkSquareF
: checkboxIsIndeterminate
? ICONS.minusSquareF
: ICONS.square
}
scale={getIconScale(this.scale)}
/>

@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-tree Issues that pertain to the calcite-tree and related components Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
5 participants
@geospatialem @DitwanP @ashetland @brittneytewks @aPreciado88