Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add round property to Split Button #7458

Open
1 of 3 tasks
Tracked by #7180
justinprather opened this issue Aug 4, 2023 · 6 comments
Open
1 of 3 tasks
Tracked by #7180

Add round property to Split Button #7458

justinprather opened this issue Aug 4, 2023 · 6 comments
Labels
0 - new New issues that need assignment. ArcGIS Hub Issues logged by ArcGIS Hub team members. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.

Comments

@justinprather
Copy link

Check existing issues

Description

Would like a way to round the corners of the Split Button.

image

⬆️ Example from me hacking in dev tools

Acceptance Criteria

I'm thinking this could be the same rounding that is provided for Button.

Relevant Info

No response

Which Component

Split Button

Example Use Case

ArcGIS Hub intends on using Buttons rounded next to a Split Button ... we'd love to these to have consistent border-radii as they exist in a grouping.

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Hub

@justinprather justinprather added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Aug 4, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Hub Issues logged by ArcGIS Hub team members. labels Aug 4, 2023
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Aug 4, 2023
@ashetland ashetland added the p - low Issue is non core or affecting less that 10% of people using the library label Aug 7, 2023
@ashetland ashetland added this to the Design Backlog milestone Aug 7, 2023
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Aug 17, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@brittneytewks
Copy link

Removed figma changes label since issue is currently in backlog and will track in monday.com once it is planned in milestone

@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Aug 28, 2024
@geospatialem
Copy link
Member

Adding additional context from @AdamWMoqrane:

image

This feature request is for a split button that retains all the existing behaviors of the current rectangular split button but incorporates a rounded style. The rounded split button will have the following characteristics:

  • Appearance: The button will feature smooth, rounded edges for a modern, polished look while maintaining the same color scheme and iconography as the rectangular split button.
  • Functionality: The split button will continue to provide the same interactive behaviors, including the ability to toggle between primary and secondary actions. Users can click the main button for the primary action or click the dropdown arrow to access additional options.
  • Responsive Design: The rounded split button will adapt to various screen sizes and maintain its functionality and aesthetics across different devices and resolutions.
  • Accessibility: Ensuring that the rounded split button is fully accessible, with appropriate ARIA labels, keyboard navigation support, and focus indicators.
  • Consistent Behavior: The split button will preserve all existing behaviors, including hover effects, click animations, and state changes (e.g., active, disabled) to ensure a seamless transition for users familiar with the rectangular version.

By implementing this rounded style, the split button will provide a visually appealing and user-friendly experience while maintaining the robust functionality users rely on.

@geospatialem geospatialem added ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. design-tokens Issues requiring design tokens. labels Aug 28, 2024
@alisonailea alisonailea self-assigned this Aug 28, 2024
@alisonailea alisonailea added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 28, 2024
@alisonailea
Copy link
Contributor

This will require button, dropdown, dropdown-item, and dropdown-group component tokens to be completed.

@geospatialem
Copy link
Member

This will require button, dropdown, dropdown-item, and dropdown-group component tokens to be completed.

Sounds like a good plan of attack, @alisonailea. Can you update the #7180 epic with the above context? cc @brittneytewks

@ashetland
Copy link
Contributor

This shouldn't need any design spec's, right? If not, we can mark this ready for dev.

@ashetland ashetland added the ready for dev Issues ready for development implementation. label Aug 30, 2024
@github-actions github-actions bot removed the 1 - assigned Issues that are assigned to a sprint and a team member. label Aug 30, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Aug 30, 2024
@github-actions github-actions bot removed this from the Design Backlog milestone Aug 30, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 30, 2024
@DitwanP DitwanP added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Hub Issues logged by ArcGIS Hub team members. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

6 participants