Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[input-number] change event not firing when clearing the input in some locale that uses comma #11324

Open
2 of 6 tasks
rpanichakit9541 opened this issue Jan 16, 2025 · 0 comments
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@rpanichakit9541
Copy link
Contributor

Check existing issues

Actual Behavior

When the input-number component is in a locale that uses comma instead of period for decimals, the calciteInputNumberChange event is not firing when the user clear the input.

Expected Behavior

the calciteInputNumberChange event should fire correctly when clearing input-number in a locale like de that uses comma.

Reproduction Sample

https://codepen.io/rpanichakit/pen/gbYKEgO?editors=1001

Reproduction Steps

  1. Click into the input and delete the content
  2. Click out
  3. Observe no change event fire/log to console
  4. Change the lang from "de" to "en"
  5. Repeat step 1-3 and see the event fire correctly and log to console

Reproduction Version

3.0.0-next.100

Relevant Info

I think this might be related to this line https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/src/components/input-number/input-number.tsx#L874 that then ends up resulting in a NaN here https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/src/utils/number.ts#L105

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

Bug found when BYS was testing setting extent coordinates in the Home app https://devtopia.esri.com/WebGIS/arcgis-portal-app/issues/55962

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online

@rpanichakit9541 rpanichakit9541 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jan 16, 2025
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

1 participant