Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a warning state in the calcite input messages component #11318

Open
2 of 5 tasks
aart7367 opened this issue Jan 16, 2025 · 2 comments
Open
2 of 5 tasks

Introduce a warning state in the calcite input messages component #11318

aart7367 opened this issue Jan 16, 2025 · 2 comments
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@aart7367
Copy link

aart7367 commented Jan 16, 2025

Check existing issues

Description

We currently have a variety of notices that are displayed to the user in a modal.

  1. Info notice to show information.
    For example the types of inputs accepted in the modal

Image

  1. Errors based on information user inputs. Here the Ok button is disabled and an error is displayed

Image

  1. A warning message based on user inputs but its a warning. User can still proceed with their action,
    We have played around with a couple of options

Image

Image

Using idle here seems odd since this is different from other places where we use this info notice and can be easily ignored. Its also not an error because the user can still proceed with their work

Acceptance Criteria

  • A warning state similar to the yellow warning notice

Image

Relevant Info

No response

Which Component

https://developers.arcgis.com/calcite-design-system/components/input-message/

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online

@aart7367 aart7367 added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jan 16, 2025
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jan 16, 2025
@macandcheese
Copy link
Contributor

There is no "warning" validity state - so we'd need to decouple the Input Message's intent a bit from being tied 1:1 to form component status. cc @SkyeSeitz @ashetland re: our conversation about a generic "message" component.

As a workaround, you can use the "valid" (or "idle") and set a css property override: https://codepen.io/mac_and_cheese/pen/jENKdNR?editors=1000

@aart7367
Copy link
Author

aart7367 commented Jan 16, 2025

@macandcheese thanks for the suggestion. The workaround might actually work for what we are trying to do. Will let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants