Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: custom colors and focus in 3.x #11303

Closed
COV-GIS opened this issue Jan 14, 2025 · 2 comments
Closed

Question: custom colors and focus in 3.x #11303

COV-GIS opened this issue Jan 14, 2025 · 2 comments

Comments

@COV-GIS
Copy link

COV-GIS commented Jan 14, 2025

I've started working/experimenting with 3.x to get ahead for migration.

All of my custom color tokens work as expected except for focus having the default color. Can't find anything inspecting elements and related shadow dom elements that would be causing this. And https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/src/assets/styles/_focus.scss#L8-L11 clearly is applying --calcite-color-brand.

Am I missing something? Or is this possibly an issue with using custom --calcite-color-brand and focus that needs to be addressed?

Image

Image

Image

@macandcheese
Copy link
Contributor

macandcheese commented Jan 14, 2025

Does using --calcite-color-focus work here?

You could set this once: --calcite-color-focus: var(--calcite-color-brand);

@alisonailea - should the above just be the default fallback?

Please let us know if you run into any other migration issues moving to 3.x.

@COV-GIS
Copy link
Author

COV-GIS commented Jan 15, 2025

Thanks @macandcheese.

That works fine. I probably should have known... #10510.

👍 on on defaulting to --calcite-color-brand.

@COV-GIS COV-GIS closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants