Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match nomenclature between scss and css #15

Open
macandcheese opened this issue Dec 10, 2019 · 0 comments
Open

Match nomenclature between scss and css #15

macandcheese opened this issue Dec 10, 2019 · 0 comments
Assignees
@julio8a

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Dec 10, 2019 •
edited
Loading

Currently the scss uses BEM for shadow :

calcite-base/dist/_variables.scss

Line 30 in d08f80c

$shadow-1--hover: 0 0 16px 0 rgba(0, 0, 0, 0.08) !default;

and the css does not:

calcite-base/dist/variables.css

Line 23 in d08f80c

--shadow-1-hover: 0 0 16px 0 rgba(0,0,0,.08);

This is kind of a weird developer experience, would make sense if they were the same. Thoughts @julio8a?
@macandcheese macandcheese changed the title Make nomenclature between scss and css match Match nomenclature between scss and css Dec 10, 2019
@julio8a julio8a mentioned this issue Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julio8a julio8a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macandcheese @julio8a