Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

fix(value-list): restore DND setup #921

Merged
merged 1 commit into from
Apr 7, 2020
Merged

fix(value-list): restore DND setup #921

merged 1 commit into from
Apr 7, 2020

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Apr 7, 2020 •
edited
Loading

Related Issue: #919

Summary

Moves value-list DND setup back to componentDidLoad. This shouldn't have moved in the first place since it doesn't kick in on DOM mutations.

cc @AdelheidF

@jcfranco jcfranco added bug Something isn't working p - high labels Apr 7, 2020
@jcfranco jcfranco added this to the KOO (King of Ooo) milestone Apr 7, 2020
@jcfranco jcfranco requested a review from driskull April 7, 2020 20:28
@jcfranco jcfranco requested a review from a team as a code owner April 7, 2020 20:28
@jcfranco jcfranco self-assigned this Apr 7, 2020
driskull
driskull approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 9f81684 into master Apr 7, 2020
@jcfranco jcfranco deleted the jcfranco/919-restore-value-list-dnd branch April 7, 2020 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Something isn't working p - high
Projects
None yet
Milestone
KOO (King of Ooo)
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull