-
Notifications
You must be signed in to change notification settings - Fork 11
feat(action-bar,action-pad): Add tooltipExpand property #904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but I have a few questions:
-
Does this mean we have to add a similar prop for any component setting the
title
attr? -
If this is a pattern we'll be applying across components, should we consider using
tooltip
as the prefix? This would be consistent w/intl
props. -
Could you also update the component's stories? 📚
@jcfranco I don't think we have to for every component but I do see the map viewer team asking for more options to include tooltips for shadowed elements so we should have a plan for this incase.
Yeah we should consider it. Would |
I'll work on a couple basic tests and stories. |
@jcfranco added usage file but can't figure out how to add story with a prop that accepts a dom node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added usage file but can't figure out how to add story with a prop that accepts a dom node.
Can you create a follow-up issue for this?
Related Issue: None
Summary
expandTooltip
property tocalcite-action-bar
andcalcite-action-pad
to show aHTMLCalciteTooltipElement
when the action is collapsed.