Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

feat(flow-item): Fix count for menu-actions #883

Merged
merged 5 commits into from
Mar 18, 2020
Merged

feat(flow-item): Fix count for menu-actions #883

merged 5 commits into from
Mar 18, 2020

Conversation

driskull
Copy link
Member

Related Issue: #882

Summary

  • Fix counting the number of actions based on slot occurrences instead of child content.
  • Clean up test apps
  • Fix tests

@driskull driskull added bug Something isn't working 1 - assigned p - medium labels Mar 18, 2020
@driskull driskull added this to the James Baxter milestone Mar 18, 2020
@driskull driskull requested review from jcfranco and asangma March 18, 2020 22:47
@driskull driskull requested a review from a team as a code owner March 18, 2020 22:47
@driskull driskull self-assigned this Mar 18, 2020
jcfranco
jcfranco approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉 🌮

@driskull driskull merged commit ace82b5 into master Mar 18, 2020
@driskull driskull deleted the dris0000/fix-menu-actions branch March 18, 2020 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@asangma asangma Awaiting requested review from asangma

Assignees

@driskull driskull

Labels
1 - assigned bug Something isn't working p - medium
Projects
None yet
Milestone
James Baxter
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco