Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

fix(block-section): increased top and bottom margins on block-section label to fix focus ring overlap #863

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

asangma
Copy link
Contributor

@asangma asangma commented Feb 28, 2020

Related Issue: #862

Summary

Slight margin tweak for focus state.

cc @bsvensson

@asangma asangma added this to the Ice King milestone Feb 28, 2020
@asangma asangma requested a review from jcfranco February 28, 2020 19:28
@asangma asangma requested a review from a team as a code owner February 28, 2020 19:28
@asangma asangma self-assigned this Feb 28, 2020
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco
Copy link
Member

fix(block-section): margin tweaks for focus state

For the changelog, could you add a little more detail to the commit message to convey what it fixes?

@asangma
Copy link
Contributor Author

asangma commented Feb 28, 2020

@jcfranco how about

fix(block-section): increased top and bottom margins on block-section label to fix focus ring overlap

@jcfranco
Copy link
Member

☝️ That's excellent!

@asangma asangma changed the title fix(block-section): margin tweaks for focus state fix(block-section): increased top and bottom margins on block-section label to fix focus ring overlap Mar 2, 2020
@jcfranco jcfranco merged commit 3b00652 into master Mar 2, 2020
@jcfranco jcfranco deleted the asangma/block-section-focus-862 branch March 2, 2020 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants