Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

feat(filter): add placeholder property #854

Merged
merged 3 commits into from
Feb 27, 2020
Merged

feat(filter): add placeholder property #854

merged 3 commits into from
Feb 27, 2020

Conversation

jcfranco
Copy link
Member

Related Issue: N/A

Summary

This adds placeholder to calcite-filter. This prop deprecates textPlaceholder since it does not have a default value and therefore does not need the text prefix.

@jcfranco
feat(filter): add placeholder property
e62c0c0 
This deprecates textPlaceholder.
@jcfranco jcfranco added the enhancement New feature request for an existing component label Feb 27, 2020
@jcfranco jcfranco added this to the Ice King milestone Feb 27, 2020
@jcfranco jcfranco requested a review from driskull February 27, 2020 06:43
@jcfranco jcfranco requested a review from a team as a code owner February 27, 2020 06:43
@jcfranco jcfranco self-assigned this Feb 27, 2020
driskull
driskull approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

driskull
driskull suggested changes Feb 27, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the placeholder need to be updated here?

calcite-app-components/src/components/calcite-filter/calcite-filter.tsx

Line 139 in e62c0c0

placeholder={this.textPlaceholder}

@jcfranco
Copy link
Member Author

lol forgot to push. #notanightowl

driskull
driskull approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit dec10b1 into master Feb 27, 2020
@jcfranco jcfranco deleted the jcfranco/add-filter-placeholder-prop branch February 27, 2020 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
enhancement New feature request for an existing component
Projects
None yet
Milestone
Ice King
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull