Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

feat(pick-list): add removable prop #820

Merged
merged 11 commits into from
Mar 2, 2020
Merged

feat(pick-list): add removable prop #820

merged 11 commits into from
Mar 2, 2020

Conversation

pr3tori4n
Copy link
Contributor

Related Issue: #753

Summary

add removable prop to pick list

@pr3tori4n pr3tori4n requested a review from a team as a code owner February 12, 2020 00:32
@pr3tori4n pr3tori4n self-assigned this Feb 12, 2020
@pr3tori4n pr3tori4n added the enhancement New feature request for an existing component label Feb 12, 2020
jcfranco
jcfranco suggested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Can you add a test for the item removal behavior?

driskull
driskull suggested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things. Looks good 👍

asangma
asangma previously requested changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@asangma asangma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing.

@driskull driskull added this to the Ice King milestone Feb 18, 2020
@pr3tori4n
Copy link
Contributor Author

Adding @driskull as an assignee in case this goes beyond today.

@jcfranco jcfranco changed the title add removable prop feat(pick-list): add removable prop Feb 27, 2020
@jcfranco jcfranco removed their request for review March 1, 2020 23:38
@jcfranco
Copy link
Member

jcfranco commented Mar 1, 2020

@driskull @asangma Could you review again? 🙇 26b2a67 has the main changes (adding test and updating demo page to leverage emitted event for item removal).

driskull
driskull approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco dismissed asangma’s stale review March 2, 2020 04:08

Dismissing since your comment was addressed.

@jcfranco jcfranco merged commit e41e460 into master Mar 2, 2020
@jcfranco jcfranco deleted the hrobbins/removable-prop-753 branch March 2, 2020 04:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@driskull driskull driskull approved these changes

@jcfranco jcfranco jcfranco approved these changes

@asangma asangma Awaiting requested review from asangma

Assignees

@jcfranco jcfranco

Labels
enhancement New feature request for an existing component
Projects
None yet
Milestone
Ice King
Development

Successfully merging this pull request may close these issues.
4 participants
@pr3tori4n @jcfranco @driskull @asangma