This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
fix: nesting and height issues #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asangma
changed the title
|
Thanks @driskull! |
|
I don't think this is the right way to go. Making Shell > Flow > Block height 100% seems very specific to the mapmaker. This is a brittle approach that makes significant assumptions about the integration pattern. Outside of this one use case, I see these heights either being inert (due to not being inside a container that has height: 100% , or causing problems by being inside a container with a defined height when the desire is not for the component to stretch. |
This is specific to full page data viz apps...the main aim of these components. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #771
Summary
Don't call it a comeback...but the 100% heights are making a comeback.
When in non-detached mode, the flow-item footers were not sticking to the bottom.
Outside components being but into flow-item will still need to set their own heights (i.e. to 100%).
Would be nice to get this into a patch maybe?