This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
feat: lists react to value prop changes in items #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
suggested changes
Jan 10, 2020
src/components/calcite-pick-list-item/calcite-pick-list-item.tsx
Outdated
Show resolved
Hide resolved
driskull
suggested changes
Jan 14, 2020
src/components/calcite-pick-list-item/calcite-pick-list-item.tsx
Outdated
Show resolved
Hide resolved
src/components/calcite-pick-list-item/calcite-pick-list-item.tsx
Outdated
Show resolved
Hide resolved
|
@driskull can we make the existing event name change in a separate PR? |
|
Yes, it can be a separate pr for |
driskull
reviewed
Jan 14, 2020
|
@driskull I added a test. Please take a second look. |
driskull
approved these changes
Jan 14, 2020
I don't believe there is an issue for it. Mind creating one? |
jcfranco
approved these changes
Jan 17, 2020
| @@ -0,0 +1,57 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
For consistency, the demo filename should be kebab-cased.
pr3tori4n
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #738
Summary
This addresses the bug Kumar raised in which if the value of an item changed after that item was selected, the parent list's Map was not updating its keys. This is due to the mutationObserver not reacting to attribute changes - which is necessary since attribute changes are too frequent.
So we added a watcher to the value prop and emit a custom event when it changes, that the list can listen to and respond accordingly.