Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

fix: keep value-list-item selected in sync with pick-list-item #623

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

driskull
Copy link
Member

Related Issue: None

Summary

  • Keep value-list-item selected in sync with pick-list-item
  • Add value to input. warning from stencil dev server [STENCIL-DEV-MODE] The "value" prop of <input> should be set after "min", "max", "type" and "step"

@driskull driskull added bug Something isn't working 1 - assigned labels Dec 10, 2019
@driskull driskull added this to the Fern milestone Dec 10, 2019
@driskull driskull requested a review from pr3tori4n December 10, 2019 18:47
@driskull driskull requested a review from a team as a code owner December 10, 2019 18:47
@driskull driskull self-assigned this Dec 10, 2019
@driskull driskull changed the title Keep value-list-item selected in sync with pick-list-item fix: keep value-list-item selected in sync with pick-list-item Dec 10, 2019
Copy link
Contributor

@pr3tori4n pr3tori4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verify this doesn't trigger redundant events

@driskull driskull merged commit 100eaf0 into master Dec 10, 2019
@driskull driskull deleted the dris0000/keep-selected-in-sync branch December 10, 2019 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 - assigned bug Something isn't working p - high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants