This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
fix: added default slots documentation #561" #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kat10140
changed the title
kat10140
changed the title
…app-components into kat10140/doc-default-slots
jcfranco
reviewed
Dec 10, 2019
| @@ -10,6 +10,7 @@ import { CalciteTheme } from "../interfaces"; | |||
| * @slot primary-panel - A slot for adding the leading `calcite-shell-panel`. | |||
| * @slot contextual-panel - A slot for adding the trailing `calcite-shell-panel`. | |||
| * @slot tip-manager - A slot for adding a `calcite-tip-manager`. This component will be absolutely positioned. | |||
| * @slot - A slot for adding content to the shell. This content will appear between any leading and trailing panels added to the shell. (eg. a map) | |||
There was a problem hiding this comment.
Nitpick: ...shell. (eg. a map) -> shell (e.g. a map).
| @@ -4,6 +4,9 @@ import { CSS } from "./resources"; | |||
|
|
|||
| import { CalciteTheme, FlowDirection } from "../interfaces"; | |||
|
|
|||
| /** | |||
| * @slot - A slot for adding `calcite-flow-items` to the flow. | |||
There was a problem hiding this comment.
Nitpick: `calcite-flow-items` -> `calcite-flow-item`s
☝️ applies to other pluralized components.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #561
Summary